From: Greg KH <gregkh@linuxfoundation.org>
To: Wayne Porter <wporter82@gmail.com>
Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/8] staging: rts5208: Fix CamelCase found by checkpatch
Date: Sun, 9 Oct 2016 16:54:03 +0200 [thread overview]
Message-ID: <20161009145403.GA18733@kroah.com> (raw)
In-Reply-To: <3715f2c8488652863fed7e33677234ba28730667.1475535232.git.wporter82@gmail.com>
On Mon, Oct 03, 2016 at 11:16:22PM +0000, Wayne Porter wrote:
> Convert CamelCase to recommended style.
>
> Signed-off-by: Wayne Porter <wporter82@gmail.com>
> ---
> drivers/staging/rts5208/xd.c | 8 ++++----
> drivers/staging/rts5208/xd.h | 8 ++++----
> 2 files changed, 8 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/staging/rts5208/xd.c b/drivers/staging/rts5208/xd.c
> index 1de02bb..1fab4ee 100644
> --- a/drivers/staging/rts5208/xd.c
> +++ b/drivers/staging/rts5208/xd.c
> @@ -693,13 +693,13 @@ static int reset_xd(struct rtsx_chip *chip)
> xd_card->zone_cnt = 32;
> xd_card->capacity = 1024000;
> break;
> - case xD_1G_X8_512:
This is probably a spec-specific define, so I wouldn't worry about the
checkpatch.pl warning for this, just leave it as-is please.
thanks,
greg k-h
next prev parent reply other threads:[~2016-10-09 15:00 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-03 23:15 [PATCH 0/8] staging: rts5208: Cleanup Wayne Porter
2016-10-03 23:16 ` [PATCH 1/8] staging: rts5208: Fix CamelCase found by checkpatch Wayne Porter
2016-10-09 14:54 ` Greg KH [this message]
2016-10-03 23:16 ` [PATCH 2/8] staging: rts5208: xd.h: Alignment fix Wayne Porter
2016-10-03 23:17 ` [PATCH 3/8] staging: rts5208: " Wayne Porter
2016-10-03 23:17 ` [PATCH 4/8] staging: rts5208: Logical continuation fixes Wayne Porter
2016-10-03 23:25 ` Joe Perches
2016-10-03 23:18 ` [PATCH 5/8] staging: rts5208: xd.c: Remove unnecessary parentheses Wayne Porter
2016-10-03 23:18 ` [PATCH 6/8] staging: rts5208: xd.c: Clean up comparison to NULL Wayne Porter
2016-10-03 23:18 ` [PATCH 7/8] staging: rts5208: xd.c: Fix CamelCase Wayne Porter
2016-10-03 23:18 ` [PATCH 8/8] staging: rts5208: xd.c: Remove multiple assignments Wayne Porter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161009145403.GA18733@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=devel@driverdev.osuosl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=wporter82@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).