From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752173AbcJIR5D (ORCPT ); Sun, 9 Oct 2016 13:57:03 -0400 Received: from verein.lst.de ([213.95.11.211]:54751 "EHLO newverein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751439AbcJIR5C (ORCPT ); Sun, 9 Oct 2016 13:57:02 -0400 Date: Sun, 9 Oct 2016 19:56:15 +0200 From: Christoph Hellwig To: Andy Shevchenko Cc: linux-kernel@vger.kernel.org Subject: pci_alloc_irq_vectors use in 8250_lpss.c Message-ID: <20161009175615.GA22239@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Andy, two comment on your ぱatch to add MSI support to the above driver. First pci_alloc_irq_vectors gained a mandatory flags argument, so for MSI suport you now need to pass PCI_IRQ_MSI in flags for the code to work. Second please make sure to always pair pci_alloc_irq_vectors with pci_free_irq_vectors on the remove path. Thanks, Christoph