From: Greg KH <gregkh@linuxfoundation.org>
To: Joe Perches <joe@perches.com>
Cc: Sabitha George <sabitha.george@gmail.com>,
wsa+renesas@sang-engineering.com, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH V2] staging: ks7010: use netdev_* instead of printk()
Date: Mon, 10 Oct 2016 07:43:09 +0200 [thread overview]
Message-ID: <20161010054309.GB23806@kroah.com> (raw)
In-Reply-To: <1476035186.2856.9.camel@perches.com>
On Sun, Oct 09, 2016 at 10:46:26AM -0700, Joe Perches wrote:
> On Sun, 2016-10-09 at 22:04 +0530, Sabitha George wrote:
> > Fixes checkpatch warning on printk usage in ks_hostif.c
> []
> > diff --git a/drivers/staging/ks7010/ks_hostif.c b/drivers/staging/ks7010/ks_hostif.c
> []
> > @@ -465,8 +465,7 @@ void hostif_data_indication(struct ks_wlan_private *priv)
> > skb->dev->last_rx = jiffies;
> > netif_rx(skb);
> > } else {
> > - printk(KERN_WARNING
> > - "ks_wlan: Memory squeeze, dropping packet.\n");
> > + netdev_warn(priv->net_dev, "ks_wlan: Memory squeeze, dropping packet.\n");
>
> You could probably drop all the "ks_wlan: " prefixes here
> and the rx_dropped increase generally removes the need
> for a non-rate-limited warning message so these
> memory squeeze messages could be removed as well.
I agree, ks_wlan: should be removed.
thanks,
greg k-h
prev parent reply other threads:[~2016-10-10 5:43 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-09 16:34 [PATCH V2] staging: ks7010: use netdev_* instead of printk() Sabitha George
2016-10-09 17:46 ` Joe Perches
2016-10-10 5:43 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161010054309.GB23806@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=devel@driverdev.osuosl.org \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sabitha.george@gmail.com \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox