Re: [linux-sunxi] [PATCH 2/5] pwm: Add Allwinner A31 SoC support

LABBE Corentin
2016-10-11T09:02:19Z

Hello

I have a minor comment below

On Tue, Oct 11, 2016 at 02:34:46PM +0800, Icenowy Zheng wrote:
> This adds a generic PWM framework driver for the PWM controller found
> on Allwinner A31 and A31s SoCs.
>
> The PWM controller is different with other Allwinner SoCs, with a
> control register per channel (in other SoCs the control register is
> shared), and each channel are allocated 16 bytes of address (but only 8
> bytes are used.)
>
> In order to use the driver for all channels, device nodes should be
> created per channel.
>
> Signed-off-by: Icenowy Zheng <icenowy@aosc.xyz>
> ---
> drivers/pwm/Kconfig | 10 ++
> drivers/pwm/Makefile | 1 +
> drivers/pwm/pwm-sun6i.c | 323 ++++++++++++++++++++++++++++++++++++++++++++++++
> 3 files changed, 334 insertions(+)
> create mode 100644 drivers/pwm/pwm-sun6i.c
>
> +
> +static int sun6i_pwm_probe(struct platform_device *pdev)
> +{
> + struct sun6i_pwm_chip *pwm;
> + struct resource *res;
> + u32 val;
> + int ret;
> + const struct of_device_id *match;
> +
> + match = of_match_device(sun6i_pwm_dt_ids, &pdev->dev);

match is not used after.

Regards

Corentin Labbe