From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752661AbcJKJjQ (ORCPT ); Tue, 11 Oct 2016 05:39:16 -0400 Received: from down.free-electrons.com ([37.187.137.238]:34462 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752209AbcJKJjO (ORCPT ); Tue, 11 Oct 2016 05:39:14 -0400 Date: Tue, 11 Oct 2016 11:36:59 +0200 From: Maxime Ripard To: Chen-Yu Tsai Cc: David Airlie , Rob Herring , Mark Rutland , dri-devel , linux-arm-kernel , linux-kernel , devicetree , linux-sunxi Subject: Re: [PATCH 2/9] drm/sun4i: tcon: Move SoC specific quirks to a DT matched data structure Message-ID: <20161011093659.GQ3462@lukather> References: <20161006160629.11198-1-wens@csie.org> <20161006160629.11198-3-wens@csie.org> <20161007083853.GH4684@lukather> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="PkEWctFf+8E2rcii" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --PkEWctFf+8E2rcii Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Oct 11, 2016 at 05:16:21PM +0800, Chen-Yu Tsai wrote: > On Fri, Oct 7, 2016 at 4:38 PM, Maxime Ripard > wrote: > > Hi, > > > > On Fri, Oct 07, 2016 at 12:06:22AM +0800, Chen-Yu Tsai wrote: > >> +struct sun4i_tcon_quirks { > >> + bool is_sun5i; /* sun5i has undocumented mux */ > >> + bool has_channel_1; /* a33 does not have channel 1 */ > >> + bool has_bypass_src; /* has separate input bypassing CEU */ > >> + bool has_dma_src; /* has DMA input */ > >> +}; > >> + > > > > I'd really prefer to keep the has_mux quirk name. is_sun5i doesn't > > really relate to what we're doing there, is redundant with the > > compatible, and render the other quirks name useless, since we could > > just have is_sun.i quirks and deal with that (which is essentially > > what we were doing before). >=20 > Lets call it has_unknown_mux then. has_mux would be confusing with > the HDMI and MIPI DSI muxes on sun6i. That works for me. Maxime --=20 Maxime Ripard, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com --PkEWctFf+8E2rcii Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJX/LK7AAoJEBx+YmzsjxAgn+gP/R/eVtlWkMa4LXC4fWjAIFXc 4r2+rxdz4VCj+I5sDL2bd4KARdvEXFaXU9bqCSMS34plzzGCKy78PZw4UbyOvae9 JU4UY83xYXHAsAybraRy4SJyhBTKytQFnmgCg8wv/Lba20mbkLt9KexdlGLdY85p HTkQTN4qU3QKZLGimYl/lI/QvkQ+DCWnTZnDektofr77LaoPmAJ6pUsrc00dnRVp GVJJr9DXF+ohGzoXj7kFzZVhjTWV9eZDPjVnM5xMnA+PpjlKJObTpZwnGE8/51Rg s3ZZT7qyAwcunzgLCo8tQfeSK8KpMyzKIu2pn68dd62S5frfDSyIB10OHuLB32WG JN4YSXVqq6m6YNSDa4nJFf+k5egU9n/l2mnPYNkkJvikzbujlJamyLeH9VNLRGOh y1TF23tgbqkbNJDjZ0YRWc8Fln9ScbD+1zJipcLUf6ifciJUae6wT5tnoS+xHUAj xp3NiSi69SrV+jcbbsJEJBHcgcrmQv93KNxeo6oMzKISz58zuJNoKkhVgcg+3eq7 iFIob3fqszS+ZlhodlLVVv7+SQOBSpKMYNQF4F8gv1lhogP/gKRUQya/Cd9C3OhB yZ1Z2W2ijMkCJlVCBf/SBVb6Bnt/NlhirsOJ1WtsV2wBx8bLE0lHBRKhC3Sfmc2e MrqChWXzlcCmwARBuWTE =r8Qp -----END PGP SIGNATURE----- --PkEWctFf+8E2rcii--