From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753599AbcJKVOY (ORCPT ); Tue, 11 Oct 2016 17:14:24 -0400 Received: from mail-pa0-f52.google.com ([209.85.220.52]:35007 "EHLO mail-pa0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752884AbcJKVOV (ORCPT ); Tue, 11 Oct 2016 17:14:21 -0400 Date: Tue, 11 Oct 2016 14:14:07 -0700 From: Stephen Hemminger To: Zach Brown Cc: f.fainelli@gmail.com, mlindner@marvell.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, devel@driverdev.osuosl.org, florian.c.schilhabel@googlemail.com, Larry.Finger@lwfinger.net, gregkh@linuxfoundation.org, rpurdie@rpsys.net, j.anaszewski@samsung.com, linux-leds@vger.kernel.org, andrew@lunn.ch Subject: Re: [PATCH v4 1/3] skge: Rename LED_OFF and LED_ON in marvel skge driver to avoid conflicts with leds namespace Message-ID: <20161011141407.3b233e83@xeon-e3> In-Reply-To: <1476217580-21229-2-git-send-email-zach.brown@ni.com> References: <1476217580-21229-1-git-send-email-zach.brown@ni.com> <1476217580-21229-2-git-send-email-zach.brown@ni.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 11 Oct 2016 15:26:18 -0500 Zach Brown wrote: > Adding led support for phy causes namespace conflicts for some > phy drivers. > > The marvel skge driver declared an enum for representing the states of > Link LED Register. The enum contained constant LED_OFF which conflicted > with declartation found in linux/leds.h. > LED_OFF changed to LED_REG_OFF > Also changed LED_ON to LED_REG_ON to avoid possible future conflict and > for consistency. > > Signed-off-by: Zach Brown Sure, that's fine but not sure why skge would be including linux/leds.h anyway.