From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752601AbcJKU53 (ORCPT ); Tue, 11 Oct 2016 16:57:29 -0400 Received: from vps0.lunn.ch ([178.209.37.122]:43608 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752537AbcJKU5X (ORCPT ); Tue, 11 Oct 2016 16:57:23 -0400 Date: Tue, 11 Oct 2016 22:56:46 +0200 From: Andrew Lunn To: Florian Fainelli Cc: Zach Brown , mlindner@marvell.com, stephen@networkplumber.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, devel@driverdev.osuosl.org, florian.c.schilhabel@googlemail.com, Larry.Finger@lwfinger.net, gregkh@linuxfoundation.org, rpurdie@rpsys.net, j.anaszewski@samsung.com, linux-leds@vger.kernel.org Subject: Re: [RFC v3 3/3] phy,leds: add support for led triggers on phy link state change Message-ID: <20161011205646.GG14094@lunn.ch> References: <1475874897-29720-1-git-send-email-zach.brown@ni.com> <1475874897-29720-4-git-send-email-zach.brown@ni.com> <1eb3afdb-0236-65e3-64be-09cc6eeda533@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1eb3afdb-0236-65e3-64be-09cc6eeda533@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > Andrew, are you happy with this implementation? Sorry, been to busy with other things to follow the discussion. What would be nice to see is a comment about how the link to LEDs in the PHYs is made. Often there is a couple of LEDs in the RJ45 socket driven by the PHY. They can show link, speed, packet Rx/Tx, etc. How are these triggers related to these LEDs? Andrew