From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932468AbcJLIe6 (ORCPT ); Wed, 12 Oct 2016 04:34:58 -0400 Received: from mail-wm0-f68.google.com ([74.125.82.68]:34237 "EHLO mail-wm0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932224AbcJLIex (ORCPT ); Wed, 12 Oct 2016 04:34:53 -0400 Date: Wed, 12 Oct 2016 10:34:50 +0200 From: Michal Hocko To: Minchan Kim Cc: Andrew Morton , Mel Gorman , Vlastimil Babka , Joonsoo Kim , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Sangseok Lee Subject: Re: [PATCH v3 3/4] mm: try to exhaust highatomic reserve before the OOM Message-ID: <20161012083449.GD17128@dhcp22.suse.cz> References: <1476259429-18279-1-git-send-email-minchan@kernel.org> <1476259429-18279-4-git-send-email-minchan@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1476259429-18279-4-git-send-email-minchan@kernel.org> User-Agent: Mutt/1.6.0 (2016-04-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Looks much better. Thanks! I am wondering whether we want to have this marked for stable. The patch is quite non-intrusive and fires only when we are really OOM. It is definitely better to try harder than go and disrupt the system by the OOM killer. So I would add Fixes: 0aaa29a56e4f ("mm, page_alloc: reserve pageblocks for high-order atomic allocations on demand") Cc: stable # 4.4+ The backport will look slightly different for kernels prior 4.6 because we do not have should_reclaim_retry yet but the check might hook right before __alloc_pages_may_oom. -- Michal Hocko SUSE Labs