From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753758AbcJLQOh (ORCPT ); Wed, 12 Oct 2016 12:14:37 -0400 Received: from mail-co1nam03on0119.outbound.protection.outlook.com ([104.47.40.119]:59616 "EHLO NAM03-CO1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753422AbcJLQOa (ORCPT ); Wed, 12 Oct 2016 12:14:30 -0400 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=zach.brown@ni.com; Date: Wed, 12 Oct 2016 10:57:58 -0500 From: Zach Brown To: Florian Fainelli CC: , , , , , , , , , , , Andrew Lunn Subject: Re: [RFC v3 3/3] phy,leds: add support for led triggers on phy link state change Message-ID: <20161012155757.GA29538@zach-desktop> References: <1475874897-29720-1-git-send-email-zach.brown@ni.com> <1475874897-29720-4-git-send-email-zach.brown@ni.com> <1eb3afdb-0236-65e3-64be-09cc6eeda533@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <1eb3afdb-0236-65e3-64be-09cc6eeda533@gmail.com> User-Agent: Mutt/1.5.24 (2015-08-30) X-Originating-IP: [130.164.62.11] X-ClientProxiedBy: BY2PR1001CA0076.namprd10.prod.outlook.com (10.164.163.44) To MWHPR04MB0625.namprd04.prod.outlook.com (10.172.166.138) X-MS-Office365-Filtering-Correlation-Id: 959e5afa-ca01-4892-7b5a-08d3f2b88db8 X-Microsoft-Exchange-Diagnostics: 1;MWHPR04MB0625;2:mQ0Fm/gs7jElbRLjvt7vntsArGc81m1rJcVY6A94liyQPlaNbfWNo4KQ95I7c+gf8qdxJTOFiGEj7fbcZQ6VN/kZQ4cwIkHJXoOrqKlKTAe7LFB1YnDCUxIRDEqfvQWvIXbIWGARZD6NFGa71Qfj98EPwYfiB95KkrMSB9KcxpoAnJVkbVdErFF2MPTTK1fxNVpWqR3QrPB/aALu+VSXAg==;3:mAaIt8Eny6/iHQdbPwQS5/OtvZd6HHLIcftsz+Zx0vf5s014b4r17Zs1LwPyE7bCqwkUHBPsaHX2blgaHLou9x8gLmd3aZgVkfhsfarvFOuQ28C52VuaydBnDg2ilrtFyW3Fv4DJKoGYa7gwX8AaTw==;25:eHIZL5Tm90eITDxLFLH1sJlc7QTCceuXaTz36ZfgwBc9A/vYLryy5KKUUOSoH1KJYl2iWl0nCARBuihWL3SzRmGLMfQkLUXR3RWTX/ISC81lRLkmJQdSdtl5IYELWeSf9M4UCd4gAO3MWf4Yf+5bLJStUmMaL/pL6I40kIqFSD/KL+Iy1NW4qVSvbK52ZHXVFuuRrphG3mwYO4AeGRHdixj3MMuU10+m6Ats3wZ8zZpmjZo77F0IF4BbK6bVRDHWH2QPor3+IiCVgUw9cVTikOrl4P0FBPJREQ6uyeAt3QdPKepk4oyhJBQsJq/lzI3kMh0Hhvs+CCYg/cloIhCXSh/7yp1EcBgZBqlbNUolXxpA24ZUZBWDRre8aUhpgF4fphId9jeBCxtH5hQsZTmvmp6jLbRKN7nETgSL3WUT4qNo9KISrhm8rqNxhQIxKOVl X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:MWHPR04MB0625; X-Microsoft-Exchange-Diagnostics: 1;MWHPR04MB0625;31:6HUIJuFRa1A8i1a2aOOX+vZYvr6iVFp6Ip/TTuk9xLUnU2mcOt+CcP7q1iXl3jhg9DWwUO1YpnpTpTqmJ7WuSjC5A95QoxvUPmbwfqPQdcDhc2dNu7j3sebF5GEEznAA95PwSDcn8wU6SuQpWmLG8j44taqC9crXa2VSioGS5ZzNJybU+WhutW2LIA+XsL8aSE4Z0eIMsfQzo/ga+9pDsBgwxV8dzb3Je2eHw4vFT/1fWQS2GE20YvG7WILL+YcQ5Ttpap0rD7jlPXXaHCbzfQ==;20:2/5v7b0qf7eQeAeNpKOwhPQZhdzl0+3hI0o3fORqgJkPGvTc4BrA2VnJMZVGNmIfBc6JqEb5i3FmM+/hLEfBRbNzdgF1Ig3oXkpmZ7UiqdzIOeDiS9B8dpv4flMX3udWu/ojTVztorOHFWgDs+lhwizHD85PAkbqApen9PeY8OQz42WbCxnyR+Za0LhvfF2X6wufBh2Ac8oBVxB/JgxSuK6GMcM50jwea1F6jYbIYzqR4s1GA4W0hwX7oO9UZXdnxF8xWD7g+CY9HFrtMztulKFUFXBvcqBvTgBPiIaHv1COLo0ff2AYCzm7TSevKgehkdmfhzHaHRMOlfHGwV9gSQpjx7WyCSb9EIP4e3fOKyMM6l5oEu5wc6R/Ful4CYdWN/GpLYdJokG1zModi3ECht+tDWBS9E+bckaQs368FPcWs8vIiXP+elKW089yp/xoxUozbJpKhn9WfiX0eZUi4uYWymA+idjb5eZRpGxqQk82ZLT8o0+HMTAPJaQTsiM8zAv+4Oad3VYDsuBRGoNsbbovT7LE14cPHVdPvlKoD5ZHfUGIWxDEe1wSsnSgMMmRUNKVKRxogsT1uMotEViF+8lZfXW6/LHxMB8bsiKKbTg= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040176)(601004)(2401047)(8121501046)(5005006)(10201501046)(3002001);SRVR:MWHPR04MB0625;BCL:0;PCL:0;RULEID:;SRVR:MWHPR04MB0625; X-Microsoft-Exchange-Diagnostics: 1;MWHPR04MB0625;4:2omt6AXL/I3ckerhfxxNEPcaAznDQZNOYgetlv86M+aB4s/Q5e70DnIfMT5YP1NPQuvVi3OFmGVcdQ3w3/k1bTV5dXnjA9Doscxf3oRjSe7w6Y9AjkVv1/4eAF4/iTmTSzq3ub7TcjWKkmwZuGfiINA2ahSPODncShImJdntNhRGbXWYS+xIS/+Vo2cEaOhAUEmALWoAtUpOVZjvhGKNiyBtaqo5yvOAuxHEC/rtIibd+qJ+BkUFXwmbTUPcpdMY1U0wXAHeKIj8M1AtQsP6wQhIOg5wF1ToLOapeaeFJsR5HPQms0Vp1+8CwqOq5zR4eatCErHCWuUuTkkTJQ632npVJWh9Pm5bBEvATmKHtrwy1BdXiTjwAiX9Ka56d6aLtaRKjTOo5TTRz8kZsWrOxJOj7FaO4qgKTO0NwFl6XBk= X-Forefront-PRVS: 0093C80C01 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(4630300001)(6009001)(7916002)(199003)(24454002)(189002)(33656002)(66066001)(86362001)(7416002)(68736007)(189998001)(110136003)(47776003)(33716001)(50466002)(4001350100001)(46406003)(50986999)(9686002)(76176999)(97756001)(54356999)(101416001)(92566002)(97736004)(106356001)(7736002)(2950100002)(6666003)(2906002)(6916009)(5660300001)(7846002)(42186005)(4326007)(1076002)(305945005)(586003)(6116002)(3846002)(81156014)(23726003)(105586002)(8676002)(81166006)(77096005)(83506001)(18370500001)(142933001)(107986001);DIR:OUT;SFP:1102;SCL:1;SRVR:MWHPR04MB0625;H:zach-desktop;FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;MWHPR04MB0625;23:XYngY784FWa0HOJXaFNr3tORkBYNgNICmaJ0pWVyc?= =?us-ascii?Q?GGijnDQd7QQz9zSZTKeZ/DtgUcihJgrmW5SEsS+JHSQ8tPKhy6OKu9407DUm?= =?us-ascii?Q?eYZEVHPHjAlNNvaqU46cbpTGTugXS/leytKNvVamRNsV8fBNo4igJ5Govswb?= =?us-ascii?Q?FYbV879sIC90Z805L5ldxlkFs+IdleUSinxIb9YWLXDASw2hX1p0Mw+kFRSc?= =?us-ascii?Q?v32XKy43Dq1zEocTntHwkUaRjVz5mTvo7ftujT0W472EAxDbYSVOnksTAFmw?= =?us-ascii?Q?g9QZMxYzXXhbCDbIVgrkgliVfySlnyY7cOfHpmOdrbTCfbn7sAgF9R0OhUs0?= =?us-ascii?Q?ok8nUTROw5bPuRqJ9dHpaii5QuuSgX+r32IdeTLVAWtjhnQe4OWw3uxgMsgW?= =?us-ascii?Q?2Gzh1LBjvxuH8NSV37FVvtoxA89QvgwmjOwkZjWfprm4CyYDnhXI0nlz4qny?= =?us-ascii?Q?sUh43balG9SvfYUEvBFWzseiRT7ZAI5A8V4qVPD5wbRlCgudcvrmy6YUDIof?= =?us-ascii?Q?SA0IvhlP5FE7Ifg4LM5L+MEIXb31mtxcERJFX5mqPUa+NOtMSr3FGzRaLm1Z?= =?us-ascii?Q?t1hhtLbRyPx7xl4lqzp5Wfj25fJ7hZDR9N9TYBsj67srY+3/Neycx+qhaCDv?= =?us-ascii?Q?q0j99eFVR15ZtY56DCWR8bec91lNw/6tPhrfNjT87mO6XhOpnzvmnJp7qq80?= =?us-ascii?Q?PMAkRIZYAtlZ6auW/XpyenkM9aU/yDqr53LMa1d2moJWZ0sU+HlbQgNBQ/Ys?= =?us-ascii?Q?nPNWyVW4VqLqVzwNXActrDFpHW8+KEbcVwjqroyw1Gg5ozJ1mJ9X/AZc7ZlZ?= =?us-ascii?Q?zq1Kdx9dv+MKbDQie39jSmsgG/GGE+IZBsM0y5ADcHJv5Cwr62lw38CZAaVT?= =?us-ascii?Q?PUn1gXsUzaN6IBVwn6JwfhKXU+sLoYwONVDtQx6qeNHTcBWZ5iaImXk2Or+U?= =?us-ascii?Q?JxlitBkGvSdLlMUQQFB9y3giKjlnMlpu9a5SNuJXd4HyTL7mj6ux9a8oVMGR?= =?us-ascii?Q?fMQJKwSGBorthWoO6CoveaSTEcLW4S8bDgdNF3KZRUeX4JuKl5WyBc+zeOkh?= =?us-ascii?Q?U1YHlOqMOoUStaxOzzbta8E5yumPD828gtC1KxepYAcI0i5B1fCUeM8yY251?= =?us-ascii?Q?Zs6ymHnoAVKwWW9i/f1Tmax1nHObXR2ux7f+tNKon7db8Ukckro24EaOxtD8?= =?us-ascii?Q?tPnnhkVwbmtBP6rjNcLjGRFNBXfx01zZsom?= X-Microsoft-Exchange-Diagnostics: 1;MWHPR04MB0625;6:qABMwJVNdX+pVAQIw4gemW9402DG45NXtMlQ/pIzxYaVGtsZQdYwEhREy9L3KY8uqvtPJPy005WNmpTN+5k7KQgUMaGbtt6TVQO2a3S2plkVcNEPA59MvUFCj7nJemLAlq9Jgx9RLHLWwWUcDDj0mBgYFPPA6k4UG5NrTCHZC5foADM9vY1DKKuF2dE8iTpp3wDqRiTI+lA0eADXrtu7VV6clNFhaZ2pys+yRS/qoVPJNAtSYeOA4pdiJMPaC0RboEFHyL0HptEKHK36fAfpndsiVfHWkD8USyCFRBnOhlL8BosK221R20K+LhI7fHo3;5:2jp9TS7Uvn54YK6+0VUAYB2UCgXynmz8QTGBi92PegFNKH8BS7SVANNVaMEZ0xnFlzD7dbqc3aF8/OpIto8fk+f7CYfXWLdNEa7eMPxbtJNzPe1S50VKRFv+m8Gy77d3xnWC77a4WFC71xlcXOSXXiM6BGTb0m2qvgDWi9aFDvg=;24:cgzAzXMa8NQ78DGAOK/qI26wGXrMFs5MKJvGJS6z1oUG+qvMnDi42Cbr61nvHK4yF+EiM+rrBDmiRyCeQ8jH8A0LU1Rk9VuyGVFSwPlfOLE=;7:INhi00gDSJ370jhssfSuPmZAAvKnWkdIA5Lt1tpJ+E/KUS4QMNa+QnNQl/FMri+lrJIRNa6T717Eof7SifLBjVuFgNPTjhDPhxRSdrj5qdEODmlJAkBNo8lrdj5GDyi6VuW1am7HdGi2hq8J7fb/NxbfINQv7pvokMEB996+uJL1AjyIT+xTEvJk6W7pE43Mz+C0seNeQfKnJUyWhE1eTmsQ02eP5WMwIEYTH1WKy4RsB6dTaZqDGr/DwzzsuxamsGXpo7fZo5O+z0vKr6mBtwUdb9pCYSywWtxxpXBN5JTl957VWRnKupsF41D3F/1Nl44Vr0s1FuoVm3M8J1Kkc2w0hhUBQGqcPyU1e1HHdLI= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: ni.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Oct 2016 15:58:04.3414 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR04MB0625 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Oct 10, 2016 at 02:03:32AM -0700, Florian Fainelli wrote: > > + > > +#ifdef CONFIG_LED_TRIGGER_PHY > > + > > +#include > > +#include > > + > > +#define PHY_LINK_LED_MAX_TRIGGERS 5 > > +#define PHY_LED_TRIGGER_SPEED_SUFFIX_SIZE 7 > > +#define PHY_MII_BUS_ID_SIZE (20 - 3) > > This particular constant may be something worth moving to > include/linux/phy.h eventually. > -- > Florian MII_BUS_ID_SIZE is defined in include/linux/phy.h but it's defined after phy_led_triggers.h is included so phy_led_triggers.h doesn't have access. I could move the definition of MII_BUS_ID_SIZE above the include, but that seemed ugly. Do you have any suggestions?