From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755345AbcJMFn4 (ORCPT ); Thu, 13 Oct 2016 01:43:56 -0400 Received: from mail-pf0-f182.google.com ([209.85.192.182]:34933 "EHLO mail-pf0-f182.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755189AbcJMFnx (ORCPT ); Thu, 13 Oct 2016 01:43:53 -0400 Date: Thu, 13 Oct 2016 11:12:11 +0530 From: Viresh Kumar To: Dave Gerlach Cc: Rafael Wysocki , nm@ti.com, sboyd@codeaurora.org, Viresh Kumar , linaro-kernel@lists.linaro.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, Vincent Guittot , robh@kernel.org, broonie@kernel.org Subject: Re: [PATCH 3/8] PM / OPP: Manage supply's voltage/current in a separate structure Message-ID: <20161013054211.GA2991@vireshk-i7> References: <57FEA7F2.3070604@ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <57FEA7F2.3070604@ti.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12-10-16, 16:15, Dave Gerlach wrote: > > /** > >+ * struct dev_pm_opp_supply - Power supply voltage/current values > >+ * @u_volt: Target voltage in microvolts corresponding to this OPP > >+ * @u_volt_min: Minimum voltage in microvolts corresponding to thisq OPP > >+ * @u_volt_max: Maximum voltage in microvolts corresponding to this OPP > >+ * @u_amp: Maximum current drawn by the device in microamperes > >+ * > >+ * This structure stores the voltage/current values for a single power supply. > >+ */ > >+struct dev_pm_opp_supply { > >+ unsigned long u_volt; > >+ unsigned long u_volt_min; > >+ unsigned long u_volt_max; > >+ unsigned long u_amp; > >+}; > >+ > >+/** > > This needs to move to include/linux/pm_opp.h, does it not? We need access to > the actual voltage values from outside of the OPP core if we are going to be > setting regulators from the platform provided opp_set_rate callback > described in patch 7. Yes, will do in V2. -- viresh