From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752224AbcJMHYd (ORCPT ); Thu, 13 Oct 2016 03:24:33 -0400 Received: from mga05.intel.com ([192.55.52.43]:30639 "EHLO mga05.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751802AbcJMHYY (ORCPT ); Thu, 13 Oct 2016 03:24:24 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.31,339,1473145200"; d="scan'208";a="1064184827" Date: Thu, 13 Oct 2016 10:22:39 +0300 From: Mika Westerberg To: Azhar Shaikh Cc: lee.jones@linaro.org, andriy.shevchenko@intel.com, heikki.krogerus@linux.intel.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mfd: intel-lpss: Do not put device in reset state on suspend Message-ID: <20161013072239.GE2774@lahna.fi.intel.com> References: <20161012171220.6429-1-azhar.shaikh@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20161012171220.6429-1-azhar.shaikh@intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.7.0 (2016-08-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Oct 12, 2016 at 10:12:20AM -0700, Azhar Shaikh wrote: > Commit 41a3da2b8e163 ("mfd: intel-lpss: Save register context on > suspend") saved the register context while going to suspend and > also put the device in reset state. > > Due to the resetting of device, system cannot enter S3/S0ix > states when no_console_suspend flag is enabled. The system > and serial console both hang. The resetting of device is not > needed while going to suspend. Hence remove this code. > > Fixes: 41a3da2b8e163 ("mfd: intel-lpss: Save register context on suspend") > Signed-off-by: Azhar Shaikh Acked-by: Mika Westerberg