From: "Radim Krčmář" <rkrcmar@redhat.com>
To: "Longpeng(Mike)" <longpeng2@huawei.com>
Cc: pbonzini@redhat.com, tglx@linutronix.de, mingo@redhat.com,
hpa@zytor.com, x86@kernel.org, kvm@vger.kernel.org,
linux-kernel@vger.kernel.org, wu.wubin@huawei.com,
zhaoshenglong@huawei.com
Subject: Re: [PATCH v2] kvm: x86: remove the misleading comment in vmx_handle_external_intr
Date: Thu, 13 Oct 2016 14:36:13 +0200 [thread overview]
Message-ID: <20161013123612.GE16406@potion> (raw)
In-Reply-To: <1476326051-83916-1-git-send-email-longpeng2@huawei.com>
2016-10-13 10:34+0800, Longpeng(Mike):
> Since Paolo has removed irq-enable-operation in vmx_handle_external_intr
> (KVM: x86: use guest_exit_irqoff), the original comment about the IF bit
> in rflags is incorrect and stale now, so remove it.
>
> Signed-off-by: Longpeng(Mike) <longpeng2@huawei.com>
> ---
> Hi Radim,
>
> Changes since v1:
> - remove this stale comment instead.
> ---
Applied to kvm/queue, thanks.
> arch/x86/kvm/vmx.c | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/arch/x86/kvm/vmx.c b/arch/x86/kvm/vmx.c
> index cf1b16d..e06c8b1 100644
> --- a/arch/x86/kvm/vmx.c
> +++ b/arch/x86/kvm/vmx.c
> @@ -8646,11 +8646,6 @@ static void vmx_handle_external_intr(struct kvm_vcpu *vcpu)
> u32 exit_intr_info = vmcs_read32(VM_EXIT_INTR_INFO);
> register void *__sp asm(_ASM_SP);
>
> - /*
> - * If external interrupt exists, IF bit is set in rflags/eflags on the
> - * interrupt stack frame, and interrupt will be enabled on a return
> - * from interrupt handler.
> - */
> if ((exit_intr_info & (INTR_INFO_VALID_MASK | INTR_INFO_INTR_TYPE_MASK))
> == (INTR_INFO_VALID_MASK | INTR_TYPE_EXT_INTR)) {
> unsigned int vector;
> --
> 1.8.3.1
>
>
prev parent reply other threads:[~2016-10-13 12:36 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-13 2:34 [PATCH v2] kvm: x86: remove the misleading comment in vmx_handle_external_intr Longpeng(Mike)
2016-10-13 12:36 ` Radim Krčmář [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161013123612.GE16406@potion \
--to=rkrcmar@redhat.com \
--cc=hpa@zytor.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=longpeng2@huawei.com \
--cc=mingo@redhat.com \
--cc=pbonzini@redhat.com \
--cc=tglx@linutronix.de \
--cc=wu.wubin@huawei.com \
--cc=x86@kernel.org \
--cc=zhaoshenglong@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox