From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S932696AbcJMOVG (ORCPT <rfc822;w@1wt.eu>);
        Thu, 13 Oct 2016 10:21:06 -0400
Received: from mail-lf0-f66.google.com ([209.85.215.66]:36081 "EHLO
        mail-lf0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S932284AbcJMOUo (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 13 Oct 2016 10:20:44 -0400
Date: Thu, 13 Oct 2016 15:05:41 +0100
From: Rui Miguel Silva <rmfrfs@gmail.com>
To: Viresh Kumar <viresh.kumar@linaro.org>
Cc: Johan Hovold <johan@kernel.org>, Alex Elder <elder@kernel.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        linaro-kernel@lists.linaro.org, linus.walleij@linaro.org,
        devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] Staging: greybus: gpio: Use gbphy_dev->dev instead
 of bundle->dev
Message-ID: <20161013140541.GA11758@arch-late.localdomain>
References: <9b48c2f62b23ef3565af2779fc2d46dcaf02d55a.1476239450.git.viresh.kumar@linaro.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Disposition: inline
In-Reply-To: <9b48c2f62b23ef3565af2779fc2d46dcaf02d55a.1476239450.git.viresh.kumar@linaro.org>
User-Agent: Mutt/1.5.24 (2015-08-30)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Viresh,
On Wed, Oct 12, 2016 at 08:02:21AM +0530, Viresh Kumar wrote:
>Some of the print messages are using the incorrect device pointer, fix
>them.
>
>Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>

Reviewed-by: Rui Miguel Silva <rmfrfs@gmail.com>

Thanks,
   Rui
>---
> drivers/staging/greybus/gpio.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
>diff --git a/drivers/staging/greybus/gpio.c b/drivers/staging/greybus/gpio.c
>index 5e06e4229e42..250caa00de5e 100644
>--- a/drivers/staging/greybus/gpio.c
>+++ b/drivers/staging/greybus/gpio.c
>@@ -702,15 +702,13 @@ static int gb_gpio_probe(struct gbphy_device *gbphy_dev,
> 	ret = gb_gpio_irqchip_add(gpio, irqc, 0,
> 				   handle_level_irq, IRQ_TYPE_NONE);
> 	if (ret) {
>-		dev_err(&connection->bundle->dev,
>-			"failed to add irq chip: %d\n", ret);
>+		dev_err(&gbphy_dev->dev, "failed to add irq chip: %d\n", ret);
> 		goto exit_line_free;
> 	}
>
> 	ret = gpiochip_add(gpio);
> 	if (ret) {
>-		dev_err(&connection->bundle->dev,
>-			"failed to add gpio chip: %d\n", ret);
>+		dev_err(&gbphy_dev->dev, "failed to add gpio chip: %d\n", ret);
> 		goto exit_gpio_irqchip_remove;
> 	}
>
>-- 
>2.7.1.410.g6faf27b
>