From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933427AbcJMTVj (ORCPT ); Thu, 13 Oct 2016 15:21:39 -0400 Received: from mail-sn1nam02on0137.outbound.protection.outlook.com ([104.47.36.137]:22896 "EHLO NAM02-SN1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1756655AbcJMTVd (ORCPT ); Thu, 13 Oct 2016 15:21:33 -0400 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=zach.brown@ni.com; Date: Thu, 13 Oct 2016 10:42:46 -0500 From: Zach Brown To: David Miller CC: , , , , , , , , , , , , Subject: Re: [PATCH v4 3/3] net: phy: leds: add support for led triggers on phy link state change Message-ID: <20161013154246.GA17387@zach-desktop> References: <1476217580-21229-1-git-send-email-zach.brown@ni.com> <1476217580-21229-4-git-send-email-zach.brown@ni.com> <20161013.104634.2079376697690971907.davem@davemloft.net> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20161013.104634.2079376697690971907.davem@davemloft.net> User-Agent: Mutt/1.5.24 (2015-08-30) X-Originating-IP: [130.164.62.11] X-ClientProxiedBy: CY1PR20CA0076.namprd20.prod.outlook.com (10.163.250.44) To MWHPR04MB0625.namprd04.prod.outlook.com (10.172.166.138) X-MS-Office365-Filtering-Correlation-Id: 29987c20-b367-4404-c81d-08d3f37f9856 X-Microsoft-Exchange-Diagnostics: 1;MWHPR04MB0625;2:Yh7SO0rye7pPzNbESqbbw1dRXWz/5xkDLf7DRq7STyuWUw8RRXfO8wUVdSKqGudXTyZj8jGMnJFLBnuXG15nsC+L6ikUHWkv1X4UlJzT3QG61hDCDPgHlsBl1alTtEPd7dweh41l0emLLqCAQnMnLPXBXxdlPq/r6QQj4OCz5bmZp8zbOCxDof8yExOnFzznAEfYeXaam+VMfIo5+Cifqw==;3:mzhNWvAAwVVALcgwrwczQcUTFtvvNsHNVtmYH+4Hm/X5K1TX73FuqlnMxfGabIr40bAyX2BwbNMCvUffrjkVbGH/DtJ3H3otFEgePzBQEiF827TjawS6iUyfXTX6pDDxMGIUXlI/R2NGvq6rTonkdg== X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:MWHPR04MB0625; X-Microsoft-Exchange-Diagnostics: 1;MWHPR04MB0625;25:AO3aTRwpIfxOxzi+WNPDJLZRkzsmiJfAloyC0IL2xxjVOs4k9V2iREMFua1c6hIgE6PFpV1ycW0FrmdTGeNHxQ5j7RTufIKZp4FsLsjZHvTo6T60gilv5r9INhUivYj8YoDyJERIbYOqzL32pbc2D3VjuYTbR5ifweEow8D2S2qcV7TwsTTF6keTXGZIthaSdi8N7heACEmcUHu+wnBrsRV01ZWK//TKktkXzSwTbhoKmiSZNo0CZJI7wGvsesQE2cZXITEBLK6mihFhdN/wKGdYzu0a994jJOlqf1RLqEvD6st6hVMHwQ3KK3Wg0KvFoXwNJSyy9W5hYel5s01fhWLWIgljNONjJ7Rz90biLQSBqbeuc9h5cpZeqXenzKyeAJdEJrF+nwxj4PZOAJMb5QspKCd2ZwHHjnsrc0n4ZHHSt3Ox/zoPU42a1H4HpfKFx4swQXwA6mQeTJBduZeNRKLaDMDXl1YspwuKPRviBLrX7BHqS2stPuY6mEivhBarQwSqZSu0VEJZSZ6mkecu8oEOq56aqI5rkVgW4o/N06jx63CvZK8/iAHuzNPca2GXvaieHJofvCubY68tsd6CTTJvayj/oTHiRoYSW+HoVCuyxEAprSbsI3lIst/FdlCIdaPvweDrQO1obVTuBMZPD8FJWe5Hrh2z63UWPRqEGboRwfZNT7TE9qHPsSLV4E6hkZmejCVC3yix2dVrxolYv+C+ZWXO5qxPmxjLXiRmOBg= X-Microsoft-Exchange-Diagnostics: 1;MWHPR04MB0625;31:wqbHx1N4HjVrA7gbCZyDI5Q0ZkZnEmHOly3pHRLY64YCS9FIhthUP7X0BYHEyqiT4kbX9CRd+ylPUI3xGAxACmvYNpYDoU+zPZHkywuT+Qeo3fu94rYyA5HLZIBUzIU9qLBnMJXN2ILWK2FSXUFBYe3YSjzm5EKif4ADQTYIw44sDeONppqVJKBQgefxRpAv3j6kO1zEWV+QTPgqzMxnnzu9xnbnicdZZ5fLHL3bUfOd62Io37gVzDANP3mczTKC1NaZL+NuJn8pJPVEmSsOBA==;20:/vJlp5NL1N0AdsAceblZOkyZ2ZMunW/J2xb4Stlep2bVqBBs9TkrYARmZMGfTFeYOumLEfW1bGv/gvlJmepx3XzmVLoYfHHB9vXJXvxtFa3I0Wqrm07zxIZ0rkSVfIuSLDzDizgrPdciEpQcc9nIDhCanAjmGSSroVMHA18NwTqM6nQc7NHhEEYnpsrBFfo87KQ2ox42hSEbRtw13+9S6QJGNDhDduMgxevvnnmz3TNqN3iiy8dLN2um+tcvLj1KjTZrAFqt4FcdCJi2VQoMhcYVpxuO3QYkDu33GlCWbS2sqdCoDY6zEdLLisaZJRSyoO+B0fUteIYb2QB66US1lyhrnBMmgJ4CFhDrtooG222pXjvc+R8DNbfMmqhPs9tNH5DOtigw8BX902v03Q6jIoAlGqQ83Y03EUAEUD+MORrxHXsGpq5JzTR7De/dN7+tl1svvmTI09PO0KGDM2MtglkouFqxeV+xa+jXKZuBmodr2W77D/WFqKkIqrNSwfmP9te1ohZAv3PXgFqgBLgH0vszsYKFgD8j65IHjc0mXezedDHobA6mIgeHtEcxCmzm5XrmyMu4vpeYMYm8ngB0o/staG0ncj8Dq0TOH6haNGQ= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(145744241990776); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040176)(601004)(2401047)(8121501046)(5005006)(10201501046)(3002001);SRVR:MWHPR04MB0625;BCL:0;PCL:0;RULEID:;SRVR:MWHPR04MB0625; X-Microsoft-Exchange-Diagnostics: 1;MWHPR04MB0625;4:h6bW/ReBmp35BVx+ssrVIQtsCeu501jWnAQ4KJgyrRGBby/LqaLtHbYlGMO3uCBbLwvQ25kzGHcWCzaa4rjOeADaULIJc3sMNF5Knmku0G7lavMuLzeuaKPH1O3rZ4YtgrfIP9tJspC10Ri2wuW1+JiLxI3mFLrHJ2thwMoyk8kIS2WZTUxCjWRnK7/AzZq8imb0QfeuGpg8cvdL6ooSbYcbrD1/WOFa8uoz/b3hA4EMFYT9qzBG11pOnXlnXZLD4CTeXrNDBqbiX5RRoVpjKnIu3FbrtCrRZf+3PVvcEJibut0MQ2IoLZVkUyF0UgNFyKCeGTYcFBT/sKSJChJsfnxgjjFU3iuWRxJCPiwNfkWVDjAUod4wedwVnapmFuAlO5tklCWETwKFesA6wnNHS0TtJ0JeEI0TD5pdRPzwrAizKqjogviQ+/VsKauCtUWavvzW51AivQAcP3HaYx3nfQ== X-Forefront-PRVS: 0094E3478A X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(4630300001)(6009001)(7916002)(189002)(199003)(24454002)(7736002)(106356001)(83506001)(92566002)(2950100002)(6666003)(6916009)(2906002)(5660300001)(7846002)(23726003)(97736004)(105586002)(8676002)(42186005)(77096005)(81166006)(1076002)(6116002)(586003)(305945005)(4326007)(3846002)(81156014)(47776003)(19580405001)(189998001)(68736007)(19580395003)(110136003)(66066001)(50466002)(33716001)(33656002)(7416002)(86362001)(97756001)(9686002)(101416001)(54356999)(76176999)(46406003)(4001350100001)(50986999)(18370500001)(107986001);DIR:OUT;SFP:1102;SCL:1;SRVR:MWHPR04MB0625;H:zach-desktop;FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;MWHPR04MB0625;23:/lOIOHGZuW2qfu9ovhSiDQZTW7VlaX1kFt5UuxwHE?= =?us-ascii?Q?XttgDVbLTtr1c9xV0ujzW9IOdYSRxyEnT7T/T6HRkO1JXRtS3FhuWgHHXMZ8?= =?us-ascii?Q?/AENgHrBG6B49zy7blXRMoLQPLCZ7ErbbvFm0tEZWSOaf+oMixz13sRulWHx?= =?us-ascii?Q?yzaXMjC69JplC5nRNF5cRj8U6YHwB5jdHBv8p1J+Zq0HXcWjo+WlF3oZxTUG?= =?us-ascii?Q?12OD5Wltiy7WCBt9FSDVa2DgNYLdMOMr+RkF/DBW5rMWFDUiMEhIwWAVeFOi?= =?us-ascii?Q?9xr3gjf1tlfA2IATtUCyWg9CxeIMOwtc5ZoU6BHhnmGEqZzz9OM9w52cs61U?= =?us-ascii?Q?fq5lufP4dI6BLKNLPCh8+cDTGWRWHSKE6X6mDFz1x1+i5M4uFO0q380UHeCQ?= =?us-ascii?Q?JpSNFf3rlgHOd7hx21Uvjv5hHjcC003MYGb9wtj0sf4ewB/ovo6s7xdXdJG/?= =?us-ascii?Q?3xYRk6q5W+cPum7s+IlQopMEdu5q1B//6BiGcHNQLG07bZoKnnhkFGL9tDu7?= =?us-ascii?Q?WdKsArfWJx3FzHwk05KcUZBi9XPlhcKBIZ7TjZeGAeTCTw81pkZSKlVZnY5Q?= =?us-ascii?Q?1gALJFfSL6UPSpYqoKH+bYGQMFb7U15I+oWRCB1Bb4S3WDEFQQhpVvhqspKr?= =?us-ascii?Q?SPngaV6RdnPhY2boErArw9CSM8XLT8MwTyV0mV1nBiMhfPTVJlZu60vkRwuf?= =?us-ascii?Q?8EJCVM1q/o/5NjOX7s+5I7PWiozUco6WZh9X9zz4PBuB9m1wDI6DhzDd7dag?= =?us-ascii?Q?4brSgTLA0er/6qknzV9Y7Gtw1crZjE1vwcGmqHJSuWiIb4RqG7nEsivU9pud?= =?us-ascii?Q?bXBMZhZizb+6RDWVdOO4A/g6O1D2o9LihcZ8FX3i43eliYYEi9wfwYZGYOx1?= =?us-ascii?Q?Zcv/sAQdLyt5fYQpAz86LcRawrIEpMmFlmAo8VcvQ6eRwnDgSkb/PP+Qifye?= =?us-ascii?Q?hzmRNeCAzLoam+390+G6/4BDlGDJ19UijK2yBqiEsSmaslfv/AIG0SS+aPN5?= =?us-ascii?Q?mWMHaVrAnmiQjCHnITWAnBF8GOVbayc/XdZzm8JnORxaXuHJoo/arqoAcBng?= =?us-ascii?Q?aNnJnFNtmkuPH3mbvpG/xW3MyOaauZqt7QxJO4LlfH2lF4xa/jg/O1WQXKw2?= =?us-ascii?Q?gLzVsHKkZfm7SO4Fo1pkYryJ9hO42BZsgcIN9LBiWQ585JfO0kGpjDt4AwBt?= =?us-ascii?Q?odl5Dij5AQCfT2j3ZC7AUbkuZN0qk0OjioZX5Pg/XNKrkevqPqIkqKB8tzMr?= =?us-ascii?Q?066N8gfRQ8v47GFQOA=3D?= X-Microsoft-Exchange-Diagnostics: 1;MWHPR04MB0625;6:34xvao9epFH+9+Ml+eNxMzdW0vhcFQobQL8sJr/YotwLo/q+OnhUq51jQBe62w+8QXP6mrfiBUEPENKsfhWts0ppCtF4jAQrD8wJODZmQ95PuX3OKyIKIrbNgsA3jpjnaecNHjMqUsZ65DMXKe8GtgSwXNkgmmE0GavVN07ipUyo7jkIRGpndv8ZcYqTOn89yWyDf6OZ2L0Mm3SnonxopX7LtzDIzaPdATRAkKWpJlumwBeqk3bwd90CgL12uCamNvvDWJEu+G63sZolFbxeZmQg/z7iFXlLm7q7OmKnprbS/5WxG5juU+0fXRzIkk4c;5:ziUqJ6Ia0gPM0NW95F90XHQOHFrWKInTa3FvUKEIsy1T6/DrQ0QdHfkBqpbFr0mQVVBF+qlNMUvFHYCizX3VPa8V5/rLpKerkMs9zBmeBfOX4nOfyp8m4jY1MFbrfaDheLtOFzFJ11DYGPn+6FSFE6WLJkNMfGj96GQf+FJJe0I=;24:SORVDjAO9pjiwgNppmFUmt+kHtJcugyWCk3L1gGFLFbS5TZUyZeZ1YaStGi+2ToutfOXKBaUe2I0BWwI88v7ic2HImAeOv8woKJ9hZIBscw=;7:NbtkvE7iL81pjekjXmVZrATAkOjLZ5c7i/38AK4j+BOrXs3PdM9SEcqT8mLdNcmBTXzu56AQsviBDA3srcsZm+u7u2368cesDn3uVSj1CPxTlQ4ydRcHQKnenXqHeegogqS5VgphkpoCEp907YlAXTKRJU/TuE2YKCMYX9Vygq5jb3f3dzqLuob9tXVKlrhjKCIOcvOxop0MSGhICG88uJzI1AXD9rrv2NIlN8M27GIcRZ3eLm7875myrS9h6jHSEw/76oMiTaZlMcjJaw4Dq7AtIr6XXEDUtZAN89HQTEpKFoLhQhzpWtKe4V5QQEs8TwCn+8LtDHRf1EXZC97Qa8zpmisx6XP2YOebyz8VHwc= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: ni.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Oct 2016 15:42:52.2944 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR04MB0625 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Oct 13, 2016 at 10:46:34AM -0400, David Miller wrote: > From: Zach Brown > Date: Tue, 11 Oct 2016 15:26:20 -0500 > > > From: Josh Cartwright > > > > Create an option CONFIG_LED_TRIGGER_PHY (default n), which will > > create a set of led triggers for each instantiated PHY device. There is > > one LED trigger per link-speed, per-phy. > > > > This allows for a user to configure their system to allow a set of LEDs > > to represent link state changes on the phy. > > > > Signed-off-by: Josh Cartwright > > Signed-off-by: Nathan Sullivan > > Signed-off-by: Zach Brown > ... > > + static const char * const name_suffix[] = { > > + "10Mbps", > > + "100Mbps", > > + "1Gbps", > > + "2.5Gbps", > > + "10Gbps", > > This choice of both the array size and the speeds to support seems > entirely arbitrary and is inappropriate for a generic driver of this > kind. > > This seems to be hard coding this to support the list of speeds > supported by whatever driver you want to use with this new LED > facility, and sorry that's not how we build nice generic pieces of > infrastructure. > > Thanks. The speeds listed are the speeds found in the phy_speed_to_str function in phy.c. They are also the speeds found in the struct phy_setting settings array, which is commented with "/* A mapping of all SUPPORTED settings to speed/duplex */" We believed they represented the commonly supported speeds of phys. Do you have suggestions on how to better handle the choice of the array size and the speeds? Thanks.