public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Nadim Almas <nadim.902@gmail.com>
Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Staging:ks7010:eap_packet: fixed 80 character line limit coding style issue
Date: Thu, 13 Oct 2016 18:21:15 +0200	[thread overview]
Message-ID: <20161013162115.GA14136@kroah.com> (raw)
In-Reply-To: <20161013160557.GA4407@gmail.com>

On Thu, Oct 13, 2016 at 09:05:57AM -0700, Nadim Almas wrote:
> Fixed coding style issue
> 
> Signed-off-by: Nadim Almas <nadim.902@gmail.com>
> ---
>  drivers/staging/ks7010/eap_packet.h | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/ks7010/eap_packet.h b/drivers/staging/ks7010/eap_packet.h
> index df7f760..90432ff 100644
> --- a/drivers/staging/ks7010/eap_packet.h
> +++ b/drivers/staging/ks7010/eap_packet.h
> @@ -58,11 +58,13 @@ struct ieee802_1x_eapol_key {
>  	 * encrypt the Key field; 64-bit NTP timestamp MAY be used here
>  	 */
>  	unsigned char replay_counter[IEEE8021X_REPLAY_COUNTER_LEN];
> -	unsigned char key_iv[IEEE8021X_KEY_IV_LEN];	/* cryptographically random number */
> +	unsigned char key_iv[IEEE8021X_KEY_IV_LEN];
> +	/* cryptographically random number */

Comment below the line?  That's not how you read code :(

  reply	other threads:[~2016-10-13 16:21 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-13 16:05 [PATCH] Staging:ks7010:eap_packet: fixed 80 character line limit coding style issue Nadim Almas
2016-10-13 16:21 ` Greg KH [this message]
     [not found]   ` <CANQNnfHK8g8VcGN7gzx+25bc7RfEiwcr7wN=b0qcqrLHS6Dg=A@mail.gmail.com>
2016-10-13 19:18     ` Greg KH
2016-10-13 19:09 ` Joe Perches

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161013162115.GA14136@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=devel@driverdev.osuosl.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nadim.902@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox