From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933711AbcJMRKx (ORCPT ); Thu, 13 Oct 2016 13:10:53 -0400 Received: from mx1.redhat.com ([209.132.183.28]:33330 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752929AbcJMRKn (ORCPT ); Thu, 13 Oct 2016 13:10:43 -0400 Date: Thu, 13 Oct 2016 19:10:35 +0200 From: Oleg Nesterov To: Al Viro Cc: Dave Chinner , Jan Kara , Nikolay Borisov , "Paul E. McKenney" , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 0/2] (Was: BUG_ON in rcu_sync_func triggered) Message-ID: <20161013171035.GA1184@redhat.com> References: <20160926160724.GA6739@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160926160724.GA6739@redhat.com> User-Agent: Mutt/1.5.24 (2015-08-30) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.39]); Thu, 13 Oct 2016 17:10:38 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 09/26, Oleg Nesterov wrote: > > Hello, > > The patches do not depend on each other. Yes, > 1/2 is the trivial fix, imo -stable material. The bug is very old it seems, > but today this race (leading to unbalanced unlock) manifests itself via > mysterious BUG_ON's in rcu/sync.c. Yes. Al, could you take it? Or how else we should route it? > 2/2 is old, I forgot to send it before. It was already reviewed by Dave and Jan, > but the generic/068 test from xfstests triggered the warning. This was fixed by > dbad7c993053 "xfs: stop holding ILOCK over filldir callbacks" so we can hopefully > kill the early-lockdep-release kludge. Lets ignore it for now, it does lead to false-positives. Thanks again Jan and Dave for your help. Oleg.