From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753207AbcJNJHz (ORCPT ); Fri, 14 Oct 2016 05:07:55 -0400 Received: from mx1.redhat.com ([209.132.183.28]:42818 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752015AbcJNJHy (ORCPT ); Fri, 14 Oct 2016 05:07:54 -0400 Date: Fri, 14 Oct 2016 11:07:50 +0200 From: Jiri Olsa To: Andi Kleen Cc: acme@kernel.org, jolsa@kernel.org, sukadev@linux.vnet.ibm.com, eranian@google.com, linux-kernel@vger.kernel.org, Andi Kleen Subject: Re: [PATCH 03/10] perf, tools: Add support for parsing uncore json files Message-ID: <20161014090750.GA11850@krava> References: <1476393332-20732-1-git-send-email-andi@firstfloor.org> <1476393332-20732-4-git-send-email-andi@firstfloor.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1476393332-20732-4-git-send-email-andi@firstfloor.org> User-Agent: Mutt/1.7.0 (2016-08-17) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.31]); Fri, 14 Oct 2016 09:07:54 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Oct 13, 2016 at 02:15:25PM -0700, Andi Kleen wrote: > From: Andi Kleen > > Handle the Unit field, which is needed to find the right PMU for > an event. We call it "pmu". Handle the ExtSel field. > Handle the Filter field. Then output the fields into the pmu-events > data structures which are compiled into perf. > > Filter out zero fields, except for the event itself. got compile error with this patch: CC util/pmu.o In file included from /usr/include/string.h:630:0, from util/util.h:55, from util/pmu.c:11: util/pmu.c: In function ‘pmu_add_cpu_aliases’: util/pmu.c:552:35: error: ‘name’ undeclared (first use in this function) if (pe->pmu && strncmp(pe->pmu, name, strlen(pe->pmu))) ^ util/pmu.c:552:35: note: each undeclared identifier is reported only once for each function it appears in mv: cannot stat 'util/.pmu.o.tmp': No such file or directory /home/jolsa/kernel/linux-perf/tools/build/Makefile.build:91: recipe for target 'util/pmu.o' failed jirka