From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932634AbcJNNRV (ORCPT ); Fri, 14 Oct 2016 09:17:21 -0400 Received: from down.free-electrons.com ([37.187.137.238]:55769 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1755208AbcJNM4E (ORCPT ); Fri, 14 Oct 2016 08:56:04 -0400 Date: Fri, 14 Oct 2016 14:55:13 +0200 From: Maxime Ripard To: Chen-Yu Tsai Cc: Icenowy Zheng , Thierry Reding , Rob Herring , Russell King , linux-pwm@vger.kernel.org, devicetree , linux-kernel , linux-sunxi Subject: Re: [linux-sunxi] [PATCH 2/5] pwm: sun4i: Add support for PWM controller on sun6i SoCs Message-ID: <20161014125513.yr5vmisywqb5tj6v@lukather> References: <20161012042059.40015-1-icenowy@aosc.xyz> <20161012042059.40015-2-icenowy@aosc.xyz> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="i3c6x2avdiyh4tll" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.6.2-neo (2016-08-21) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --i3c6x2avdiyh4tll Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Oct 12, 2016 at 03:30:07PM +0800, Chen-Yu Tsai wrote: > Hi, >=20 > On Wed, Oct 12, 2016 at 12:20 PM, Icenowy Zheng wrote: > > The PWM controller in A31 is different with other Allwinner SoCs, with a > > control register per channel (in other SoCs the control register is > > shared), and each channel are allocated 16 bytes of address (but only 8 > > bytes are used.). The register map in one channel is just like a > > single-channel A10 PWM controller, however, A31 have a different > > prescaler table than other SoCs. > > > > In order to use the driver for all 4 channels, device nodes should be > > created per channel. >=20 > I think Maxime wants you to support the different register offsets > in this driver, and have all 4 channels in the same device (node). Indeed. Maxime --=20 Maxime Ripard, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com --i3c6x2avdiyh4tll Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIcBAEBCAAGBQJYANWrAAoJEBx+YmzsjxAgKmQQALyem9Pni8KUppFks1IxD3XT CknaGnUz8/TO9bXkCIZbwIesJtjqnaOchpME+ncFvJshy0NIsNSx6Tdzz8FhcNd3 aozQ/Y2RTQ9HLt4cXqL60nTI0cnCsSnoMO1eg3/x0PHUiEWhrhQk0+gyDquDnBXm gy0CyAShe8FEYV/c+ykJbV8bldvG+5k/Wi2jZsbu4CvFBzZPGmgx7Ki0T2Ynnjvq JwjBHB/9BRxw8V3AYck3gaSRFw05PWMOZ2ysdsfJ59Ubwudc9ccTzf8jR7g+4Q29 sh/mZhsJstyrCy0mkpXUZpQbesmY0M+T9PThXvnXZImcR8YqJV+g9JTE8jGx+Onj BP5dtprukDvHzzvNtBOQG00XizpX3CEUlFWEUyk7Dn8B3XxpzMbRfHnafdAlyvFo Cr8T06yFhzi0eFhGGt8HnAGSc5QKeDpplVxw0oq6YdXejO+FWYrMRBxCeMTM+sy4 vGJIAp/SIps/B4pMhHCTr6DA99W4N/w/i5Ky6Lruv3MK0vwCnQeWyaJ4rnDxixvq g2fiEH4qu5XKqrzaoeqN8ppSCLo2CfdsXQIkBAgMsr1RncYUNRQPs9UxDVA4VIOT +N6PWGK0XRB8KEb9jaeuJYopuHFfv1wyLYB0IGD8pau43xtlLiUv5BSL0BntTqgp X4rpoTSQuL/NMsAe+t0t =rBs9 -----END PGP SIGNATURE----- --i3c6x2avdiyh4tll--