* Add "lightnvm: ensure that nvm_dev_ops can be used without CONFIG_NVM" to v4.4.y stable tree?
@ 2016-10-14 13:28 Paul Bolle
2016-10-14 13:47 ` Greg KH
0 siblings, 1 reply; 3+ messages in thread
From: Paul Bolle @ 2016-10-14 13:28 UTC (permalink / raw)
To: Jens Axboe; +Cc: Greg KH, linux-kernel
Hi,
I had a build of v4.4.24, with CONFIG_NVM not set, fail like this:
drivers/block/null_blk.c:569:27: error: storage size of 'null_lnvm_dev_ops' isn't known
static struct nvm_dev_ops null_lnvm_dev_ops;
^~~~~~~~~~~~~~~~~
scripts/Makefile.build:264: recipe for target 'drivers/block/null_blk.o' failed
make[2]: *** [drivers/block/null_blk.o] Error 1
scripts/Makefile.build:403: recipe for target 'drivers/block' failed
make[1]: *** [drivers/block] Error 2
Makefile:959: recipe for target 'drivers' failed
make: *** [drivers] Error 2
Jens' commit a7fd9a4f3e81 ("lightnvm: ensure that nvm_dev_ops can be
used without CONFIG_NVM") fixed that for me (it did require a small
context change to get it applied to v4.4.24). Does it make sense to add
that commit to the v4.4.y stable tree?
Thanks,
Paul Bolle
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: Add "lightnvm: ensure that nvm_dev_ops can be used without CONFIG_NVM" to v4.4.y stable tree?
2016-10-14 13:28 Add "lightnvm: ensure that nvm_dev_ops can be used without CONFIG_NVM" to v4.4.y stable tree? Paul Bolle
@ 2016-10-14 13:47 ` Greg KH
2016-10-14 16:30 ` Paul Bolle
0 siblings, 1 reply; 3+ messages in thread
From: Greg KH @ 2016-10-14 13:47 UTC (permalink / raw)
To: Paul Bolle; +Cc: Jens Axboe, linux-kernel, stable
On Fri, Oct 14, 2016 at 03:28:41PM +0200, Paul Bolle wrote:
> Hi,
>
> I had a build of v4.4.24, with CONFIG_NVM not set, fail like this:
> drivers/block/null_blk.c:569:27: error: storage size of 'null_lnvm_dev_ops' isn't known
> static struct nvm_dev_ops null_lnvm_dev_ops;
> ^~~~~~~~~~~~~~~~~
> scripts/Makefile.build:264: recipe for target 'drivers/block/null_blk.o' failed
> make[2]: *** [drivers/block/null_blk.o] Error 1
> scripts/Makefile.build:403: recipe for target 'drivers/block' failed
> make[1]: *** [drivers/block] Error 2
> Makefile:959: recipe for target 'drivers' failed
> make: *** [drivers] Error 2
>
> Jens' commit a7fd9a4f3e81 ("lightnvm: ensure that nvm_dev_ops can be
> used without CONFIG_NVM") fixed that for me (it did require a small
> context change to get it applied to v4.4.24). Does it make sense to add
> that commit to the v4.4.y stable tree?
Makes sense to me, can you forward on a patch that applies cleanly and
I'll queue it up for the next round (after this one.)
thanks,
greg k-h
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: Add "lightnvm: ensure that nvm_dev_ops can be used without CONFIG_NVM" to v4.4.y stable tree?
2016-10-14 13:47 ` Greg KH
@ 2016-10-14 16:30 ` Paul Bolle
0 siblings, 0 replies; 3+ messages in thread
From: Paul Bolle @ 2016-10-14 16:30 UTC (permalink / raw)
To: Greg KH; +Cc: Jens Axboe, linux-kernel, stable
On Fri, 2016-10-14 at 15:47 +0200, Greg KH wrote:
> Makes sense to me, can you forward on a patch that applies cleanly and
> I'll queue it up for the next round (after this one.)
Hope to do that later today. If it turns out I've messed things up Jens
can still speak up.
Thanks,
Paul Bolle
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-10-14 16:30 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-10-14 13:28 Add "lightnvm: ensure that nvm_dev_ops can be used without CONFIG_NVM" to v4.4.y stable tree? Paul Bolle
2016-10-14 13:47 ` Greg KH
2016-10-14 16:30 ` Paul Bolle
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox