From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754024AbcJNPdG (ORCPT ); Fri, 14 Oct 2016 11:33:06 -0400 Received: from one.firstfloor.org ([193.170.194.197]:59958 "EHLO one.firstfloor.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752589AbcJNPcv (ORCPT ); Fri, 14 Oct 2016 11:32:51 -0400 Date: Fri, 14 Oct 2016 08:32:22 -0700 From: Andi Kleen To: Jiri Olsa Cc: Andi Kleen , acme@kernel.org, jolsa@kernel.org, sukadev@linux.vnet.ibm.com, eranian@google.com, linux-kernel@vger.kernel.org, Andi Kleen Subject: Re: [PATCH 03/10] perf, tools: Add support for parsing uncore json files Message-ID: <20161014153222.GH26852@two.firstfloor.org> References: <1476393332-20732-1-git-send-email-andi@firstfloor.org> <1476393332-20732-4-git-send-email-andi@firstfloor.org> <20161014122334.GC1356@krava> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20161014122334.GC1356@krava> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > > addfield(map, &extra_desc, ". ", > > " Supports address when precise", > > NULL); > > + } else if (json_streq(map, field, "Unit")) { > > so I remember you said you're preparing JSON events files for perf, > so why not call this field "Pmu" directly? Would be less confusing > wrt the ScaleUnit field While I'm cleaning up the files somewhat, I'm still trying to be compatible with the original format, so that it's also possible to drop in unchanged files. Also it's better if there is only one kind of JSON event format, not multiple subtle incompatible versions. -Andi