linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Andi Kleen <andi@firstfloor.org>
Cc: jolsa@kernel.org, sukadev@linux.vnet.ibm.com, eranian@google.com,
	linux-kernel@vger.kernel.org, Andi Kleen <ak@linux.intel.com>
Subject: Re: [PATCH 02/10] perf, tools: Only print Using CPUID message once
Date: Fri, 14 Oct 2016 12:44:18 -0300	[thread overview]
Message-ID: <20161014154418.GE12815@kernel.org> (raw)
In-Reply-To: <1476393332-20732-3-git-send-email-andi@firstfloor.org>

Em Thu, Oct 13, 2016 at 02:15:24PM -0700, Andi Kleen escreveu:
> From: Andi Kleen <ak@linux.intel.com>
> 
> With uncore event aliases which are duplicated over multiple PMUs
> the "Using CPUID" message with -v could be printed many times.
> Only print it once.

Thanks, applied.

- Arnaldo
 
> Signed-off-by: Andi Kleen <ak@linux.intel.com>
> ---
>  tools/perf/util/pmu.c | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
> 
> diff --git a/tools/perf/util/pmu.c b/tools/perf/util/pmu.c
> index 9adae7e7477c..b36bf9e77799 100644
> --- a/tools/perf/util/pmu.c
> +++ b/tools/perf/util/pmu.c
> @@ -508,6 +508,7 @@ static void pmu_add_cpu_aliases(struct list_head *head)
>  	struct pmu_events_map *map;
>  	struct pmu_event *pe;
>  	char *cpuid;
> +	static bool printed;
>  
>  	cpuid = getenv("PERF_CPUID");
>  	if (cpuid)
> @@ -517,7 +518,10 @@ static void pmu_add_cpu_aliases(struct list_head *head)
>  	if (!cpuid)
>  		return;
>  
> -	pr_debug("Using CPUID %s\n", cpuid);
> +	if (!printed) {
> +		pr_debug("Using CPUID %s\n", cpuid);
> +		printed = true;
> +	}
>  
>  	i = 0;
>  	while (1) {
> -- 
> 2.5.5

  reply	other threads:[~2016-10-14 15:44 UTC|newest]

Thread overview: 44+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-13 21:15 Support Intel uncore event lists Andi Kleen
2016-10-13 21:15 ` [PATCH 01/10] perf, tools: Factor out scale conversion code Andi Kleen
2016-10-14 15:35   ` Arnaldo Carvalho de Melo
2016-10-14 15:45     ` Andi Kleen
2016-10-14 16:08       ` Arnaldo Carvalho de Melo
2016-10-14 16:15         ` Andi Kleen
2016-10-14 16:25           ` Arnaldo Carvalho de Melo
2016-10-14 16:36             ` Andi Kleen
2016-10-14 16:38               ` Arnaldo Carvalho de Melo
2016-10-13 21:15 ` [PATCH 02/10] perf, tools: Only print Using CPUID message once Andi Kleen
2016-10-14 15:44   ` Arnaldo Carvalho de Melo [this message]
2016-10-24 19:02   ` [tip:perf/core] perf pmu: " tip-bot for Andi Kleen
2016-10-13 21:15 ` [PATCH 03/10] perf, tools: Add support for parsing uncore json files Andi Kleen
2016-10-14  9:07   ` Jiri Olsa
2016-10-14 12:18   ` Jiri Olsa
2016-10-14 12:21   ` Jiri Olsa
2016-10-14 12:23   ` Jiri Olsa
2016-10-14 15:32     ` Andi Kleen
2016-10-13 21:15 ` [PATCH 04/10] perf, tools: Support per pmu json aliases Andi Kleen
2016-10-14 12:31   ` Jiri Olsa
2016-10-13 21:15 ` [PATCH 05/10] perf, tools: Support event aliases for non cpu// pmus Andi Kleen
2016-10-17  9:35   ` Jiri Olsa
2016-10-17 10:28   ` Jiri Olsa
2016-10-13 21:15 ` [PATCH 06/10] perf, tools: Add debug support for outputing alias string Andi Kleen
2016-10-13 21:15 ` [PATCH 07/10] perf, tools: Collapse identically named events in perf stat Andi Kleen
2016-10-17 10:55   ` Jiri Olsa
2016-10-17 11:23   ` Jiri Olsa
2016-10-17 11:26   ` Jiri Olsa
2016-10-17 16:30     ` Andi Kleen
2016-10-17 17:28       ` Jiri Olsa
2016-10-17 18:12         ` Andi Kleen
2016-10-13 21:15 ` [PATCH 08/10] perf, tools: Expand PMU events by prefix match Andi Kleen
2016-10-17 11:35   ` Jiri Olsa
2016-10-17 11:40   ` Jiri Olsa
2016-10-17 16:56     ` Andi Kleen
2016-10-17 17:26       ` Jiri Olsa
2016-10-13 21:15 ` [PATCH 09/10] perf, tools: Support DividedBy header in JSON event list Andi Kleen
2016-10-17 11:44   ` Jiri Olsa
2016-10-17 16:27     ` Andi Kleen
2016-10-17 17:43       ` Jiri Olsa
2016-10-17 17:46         ` Jiri Olsa
2016-10-17 18:28         ` Andi Kleen
2016-10-13 21:15 ` [PATCH 10/10] perf, tools, stat: Output generic dividedby metric Andi Kleen
2016-10-17 10:58 ` Support Intel uncore event lists Jiri Olsa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161014154418.GE12815@kernel.org \
    --to=acme@kernel.org \
    --cc=ak@linux.intel.com \
    --cc=andi@firstfloor.org \
    --cc=eranian@google.com \
    --cc=jolsa@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sukadev@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).