From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755379AbcJNQQp (ORCPT ); Fri, 14 Oct 2016 12:16:45 -0400 Received: from mail.kernel.org ([198.145.29.136]:53766 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755285AbcJNQQi (ORCPT ); Fri, 14 Oct 2016 12:16:38 -0400 Date: Fri, 14 Oct 2016 13:08:42 -0300 From: Arnaldo Carvalho de Melo To: Andi Kleen Cc: jolsa@kernel.org, sukadev@linux.vnet.ibm.com, eranian@google.com, linux-kernel@vger.kernel.org, Andi Kleen Subject: Re: [PATCH 01/10] perf, tools: Factor out scale conversion code Message-ID: <20161014160842.GI12815@kernel.org> References: <1476393332-20732-1-git-send-email-andi@firstfloor.org> <1476393332-20732-2-git-send-email-andi@firstfloor.org> <20161014153557.GD12815@kernel.org> <20161014154514.GI26852@two.firstfloor.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20161014154514.GI26852@two.firstfloor.org> X-Url: http://acmel.wordpress.com User-Agent: Mutt/1.7.0 (2016-08-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Em Fri, Oct 14, 2016 at 08:45:15AM -0700, Andi Kleen escreveu: > > So if we can't convert the scale because of an allocation failure > > related to locale issues we silently trow it away and do no scale at > > all? > That is right. If your machine is thrashing to death in a OOM this > is your smallest problem. Please keep it was before, i.e. return an error value, and bail out. It was like that before, why introduce these kinds of silent "do something else in an unlikely case" handling? - Arnaldo