From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755329AbcJNQgx (ORCPT ); Fri, 14 Oct 2016 12:36:53 -0400 Received: from one.firstfloor.org ([193.170.194.197]:60183 "EHLO one.firstfloor.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753771AbcJNQgp (ORCPT ); Fri, 14 Oct 2016 12:36:45 -0400 Date: Fri, 14 Oct 2016 09:36:42 -0700 From: Andi Kleen To: Arnaldo Carvalho de Melo Cc: Andi Kleen , Andi Kleen , jolsa@kernel.org, sukadev@linux.vnet.ibm.com, eranian@google.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH 01/10] perf, tools: Factor out scale conversion code Message-ID: <20161014163641.GJ26852@two.firstfloor.org> References: <1476393332-20732-1-git-send-email-andi@firstfloor.org> <1476393332-20732-2-git-send-email-andi@firstfloor.org> <20161014153557.GD12815@kernel.org> <20161014154514.GI26852@two.firstfloor.org> <20161014160842.GI12815@kernel.org> <20161014161516.GJ3078@tassilo.jf.intel.com> <20161014162511.GJ12815@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20161014162511.GJ12815@kernel.org> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > I tools/ specifically, I try to use the same constructs, list.h, rbtree, > WARN_, pr_, etc, not panic()'ing, etc. > > In this specific case, doing a: > > printf("life is hard, I give up"); exit(1); Ok that would be just what a wrapper does, only open coded. How about we just add helpers for these cases? xstrdup xmalloc xasprintf etc. -Andi