From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Andi Kleen <andi@firstfloor.org>
Cc: Andi Kleen <ak@linux.intel.com>,
jolsa@kernel.org, sukadev@linux.vnet.ibm.com, eranian@google.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 01/10] perf, tools: Factor out scale conversion code
Date: Fri, 14 Oct 2016 13:38:17 -0300 [thread overview]
Message-ID: <20161014163817.GK12815@kernel.org> (raw)
In-Reply-To: <20161014163641.GJ26852@two.firstfloor.org>
Em Fri, Oct 14, 2016 at 09:36:42AM -0700, Andi Kleen escreveu:
> > I tools/ specifically, I try to use the same constructs, list.h, rbtree,
> > WARN_, pr_, etc, not panic()'ing, etc.
> >
> > In this specific case, doing a:
> >
> > printf("life is hard, I give up"); exit(1);
>
> Ok that would be just what a wrapper does, only open coded.
>
> How about we just add helpers for these cases?
>
> xstrdup
> xmalloc
> xasprintf
Nope, we had those, I removed them already.
- Arnaldo
next prev parent reply other threads:[~2016-10-14 16:39 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-13 21:15 Support Intel uncore event lists Andi Kleen
2016-10-13 21:15 ` [PATCH 01/10] perf, tools: Factor out scale conversion code Andi Kleen
2016-10-14 15:35 ` Arnaldo Carvalho de Melo
2016-10-14 15:45 ` Andi Kleen
2016-10-14 16:08 ` Arnaldo Carvalho de Melo
2016-10-14 16:15 ` Andi Kleen
2016-10-14 16:25 ` Arnaldo Carvalho de Melo
2016-10-14 16:36 ` Andi Kleen
2016-10-14 16:38 ` Arnaldo Carvalho de Melo [this message]
2016-10-13 21:15 ` [PATCH 02/10] perf, tools: Only print Using CPUID message once Andi Kleen
2016-10-14 15:44 ` Arnaldo Carvalho de Melo
2016-10-24 19:02 ` [tip:perf/core] perf pmu: " tip-bot for Andi Kleen
2016-10-13 21:15 ` [PATCH 03/10] perf, tools: Add support for parsing uncore json files Andi Kleen
2016-10-14 9:07 ` Jiri Olsa
2016-10-14 12:18 ` Jiri Olsa
2016-10-14 12:21 ` Jiri Olsa
2016-10-14 12:23 ` Jiri Olsa
2016-10-14 15:32 ` Andi Kleen
2016-10-13 21:15 ` [PATCH 04/10] perf, tools: Support per pmu json aliases Andi Kleen
2016-10-14 12:31 ` Jiri Olsa
2016-10-13 21:15 ` [PATCH 05/10] perf, tools: Support event aliases for non cpu// pmus Andi Kleen
2016-10-17 9:35 ` Jiri Olsa
2016-10-17 10:28 ` Jiri Olsa
2016-10-13 21:15 ` [PATCH 06/10] perf, tools: Add debug support for outputing alias string Andi Kleen
2016-10-13 21:15 ` [PATCH 07/10] perf, tools: Collapse identically named events in perf stat Andi Kleen
2016-10-17 10:55 ` Jiri Olsa
2016-10-17 11:23 ` Jiri Olsa
2016-10-17 11:26 ` Jiri Olsa
2016-10-17 16:30 ` Andi Kleen
2016-10-17 17:28 ` Jiri Olsa
2016-10-17 18:12 ` Andi Kleen
2016-10-13 21:15 ` [PATCH 08/10] perf, tools: Expand PMU events by prefix match Andi Kleen
2016-10-17 11:35 ` Jiri Olsa
2016-10-17 11:40 ` Jiri Olsa
2016-10-17 16:56 ` Andi Kleen
2016-10-17 17:26 ` Jiri Olsa
2016-10-13 21:15 ` [PATCH 09/10] perf, tools: Support DividedBy header in JSON event list Andi Kleen
2016-10-17 11:44 ` Jiri Olsa
2016-10-17 16:27 ` Andi Kleen
2016-10-17 17:43 ` Jiri Olsa
2016-10-17 17:46 ` Jiri Olsa
2016-10-17 18:28 ` Andi Kleen
2016-10-13 21:15 ` [PATCH 10/10] perf, tools, stat: Output generic dividedby metric Andi Kleen
2016-10-17 10:58 ` Support Intel uncore event lists Jiri Olsa
-- strict thread matches above, loose matches on Subject: below --
2016-11-19 0:36 Support Intel uncore event lists in perf Andi Kleen
2016-11-19 0:36 ` [PATCH 01/10] perf, tools: Factor out scale conversion code Andi Kleen
2016-11-23 9:26 ` Jiri Olsa
2016-11-23 9:46 ` Jiri Olsa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161014163817.GK12815@kernel.org \
--to=acme@kernel.org \
--cc=ak@linux.intel.com \
--cc=andi@firstfloor.org \
--cc=eranian@google.com \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sukadev@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).