From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752731AbcJOGa4 (ORCPT ); Sat, 15 Oct 2016 02:30:56 -0400 Received: from mail-wm0-f66.google.com ([74.125.82.66]:35364 "EHLO mail-wm0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751449AbcJOGas (ORCPT ); Sat, 15 Oct 2016 02:30:48 -0400 Date: Sat, 15 Oct 2016 08:30:43 +0200 From: Ingo Molnar To: Dmitry Vyukov Cc: rostedt@goodmis.org, mingo@redhat.com, akpm@linux-foundation.org, linux-kernel@vger.kernel.org, ryabinin.a.a@gmail.com, surovegin@google.com, Mark Rutland , Catalin Marinas , Lorenzo Pieralisi , Alexander Potapenko , Will Deacon , Thomas Gleixner , "H. Peter Anvin" , Ananth N Mavinakayanahalli , Anil S Keshavamurthy , "David S. Miller" , Masami Hiramatsu , x86@kernel.org, kasan-dev@googlegroups.com Subject: Re: [PATCH v5] kprobes: unpoison stack in jprobe_return() for KASAN Message-ID: <20161015063043.GA22225@gmail.com> References: <1476454043-101898-1-git-send-email-dvyukov@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1476454043-101898-1-git-send-email-dvyukov@google.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Dmitry Vyukov wrote: > KASAN stack instrumentation poisons stack redzones on function entry > and unpoisons them on function exit. If a function exits abnormally > (e.g. with a longjmp like jprobe_return()), stack redzones are left > poisoned. Later this leads to random KASAN false reports. > > Unpoison stack redzones in the frames we are going to jump over > before doing actual longjmp in jprobe_return(). Does this affect any other architecture besides arm64? If not then it might make the most sense to merge this via the arm64 tree. Thanks, Ingo