* [PATCH 1/2] Staging: greybus: gpio: Use gbphy_dev->dev instead of bundle->dev
@ 2016-10-12 2:32 Viresh Kumar
2016-10-12 2:32 ` [PATCH 2/2] Staging: greybus: uart: " Viresh Kumar
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Viresh Kumar @ 2016-10-12 2:32 UTC (permalink / raw)
To: Rui Miguel Silva, Johan Hovold, Alex Elder, Greg Kroah-Hartman
Cc: linaro-kernel, linus.walleij, Viresh Kumar, devel, linux-kernel
Some of the print messages are using the incorrect device pointer, fix
them.
Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
---
drivers/staging/greybus/gpio.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/greybus/gpio.c b/drivers/staging/greybus/gpio.c
index 5e06e4229e42..250caa00de5e 100644
--- a/drivers/staging/greybus/gpio.c
+++ b/drivers/staging/greybus/gpio.c
@@ -702,15 +702,13 @@ static int gb_gpio_probe(struct gbphy_device *gbphy_dev,
ret = gb_gpio_irqchip_add(gpio, irqc, 0,
handle_level_irq, IRQ_TYPE_NONE);
if (ret) {
- dev_err(&connection->bundle->dev,
- "failed to add irq chip: %d\n", ret);
+ dev_err(&gbphy_dev->dev, "failed to add irq chip: %d\n", ret);
goto exit_line_free;
}
ret = gpiochip_add(gpio);
if (ret) {
- dev_err(&connection->bundle->dev,
- "failed to add gpio chip: %d\n", ret);
+ dev_err(&gbphy_dev->dev, "failed to add gpio chip: %d\n", ret);
goto exit_gpio_irqchip_remove;
}
--
2.7.1.410.g6faf27b
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH 2/2] Staging: greybus: uart: Use gbphy_dev->dev instead of bundle->dev
2016-10-12 2:32 [PATCH 1/2] Staging: greybus: gpio: Use gbphy_dev->dev instead of bundle->dev Viresh Kumar
@ 2016-10-12 2:32 ` Viresh Kumar
2016-10-15 11:20 ` Johan Hovold
2016-10-13 14:05 ` [PATCH 1/2] Staging: greybus: gpio: " Rui Miguel Silva
2016-10-15 11:18 ` Johan Hovold
2 siblings, 1 reply; 5+ messages in thread
From: Viresh Kumar @ 2016-10-12 2:32 UTC (permalink / raw)
To: David Lin, Johan Hovold, Alex Elder, Greg Kroah-Hartman
Cc: linaro-kernel, linus.walleij, Viresh Kumar, devel, linux-kernel
Some of the print messages are using the incorrect device pointer, fix
them.
Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
---
drivers/staging/greybus/uart.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/greybus/uart.c b/drivers/staging/greybus/uart.c
index 5ee7954bd9f9..2633d2bfb1b4 100644
--- a/drivers/staging/greybus/uart.c
+++ b/drivers/staging/greybus/uart.c
@@ -888,7 +888,7 @@ static int gb_uart_probe(struct gbphy_device *gbphy_dev,
minor = alloc_minor(gb_tty);
if (minor < 0) {
if (minor == -ENOSPC) {
- dev_err(&connection->bundle->dev,
+ dev_err(&gbphy_dev->dev,
"no more free minor numbers\n");
retval = -ENODEV;
} else {
--
2.7.1.410.g6faf27b
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH 1/2] Staging: greybus: gpio: Use gbphy_dev->dev instead of bundle->dev
2016-10-12 2:32 [PATCH 1/2] Staging: greybus: gpio: Use gbphy_dev->dev instead of bundle->dev Viresh Kumar
2016-10-12 2:32 ` [PATCH 2/2] Staging: greybus: uart: " Viresh Kumar
@ 2016-10-13 14:05 ` Rui Miguel Silva
2016-10-15 11:18 ` Johan Hovold
2 siblings, 0 replies; 5+ messages in thread
From: Rui Miguel Silva @ 2016-10-13 14:05 UTC (permalink / raw)
To: Viresh Kumar
Cc: Johan Hovold, Alex Elder, Greg Kroah-Hartman, linaro-kernel,
linus.walleij, devel, linux-kernel
Hi Viresh,
On Wed, Oct 12, 2016 at 08:02:21AM +0530, Viresh Kumar wrote:
>Some of the print messages are using the incorrect device pointer, fix
>them.
>
>Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
Reviewed-by: Rui Miguel Silva <rmfrfs@gmail.com>
Thanks,
Rui
>---
> drivers/staging/greybus/gpio.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
>diff --git a/drivers/staging/greybus/gpio.c b/drivers/staging/greybus/gpio.c
>index 5e06e4229e42..250caa00de5e 100644
>--- a/drivers/staging/greybus/gpio.c
>+++ b/drivers/staging/greybus/gpio.c
>@@ -702,15 +702,13 @@ static int gb_gpio_probe(struct gbphy_device *gbphy_dev,
> ret = gb_gpio_irqchip_add(gpio, irqc, 0,
> handle_level_irq, IRQ_TYPE_NONE);
> if (ret) {
>- dev_err(&connection->bundle->dev,
>- "failed to add irq chip: %d\n", ret);
>+ dev_err(&gbphy_dev->dev, "failed to add irq chip: %d\n", ret);
> goto exit_line_free;
> }
>
> ret = gpiochip_add(gpio);
> if (ret) {
>- dev_err(&connection->bundle->dev,
>- "failed to add gpio chip: %d\n", ret);
>+ dev_err(&gbphy_dev->dev, "failed to add gpio chip: %d\n", ret);
> goto exit_gpio_irqchip_remove;
> }
>
>--
>2.7.1.410.g6faf27b
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 1/2] Staging: greybus: gpio: Use gbphy_dev->dev instead of bundle->dev
2016-10-12 2:32 [PATCH 1/2] Staging: greybus: gpio: Use gbphy_dev->dev instead of bundle->dev Viresh Kumar
2016-10-12 2:32 ` [PATCH 2/2] Staging: greybus: uart: " Viresh Kumar
2016-10-13 14:05 ` [PATCH 1/2] Staging: greybus: gpio: " Rui Miguel Silva
@ 2016-10-15 11:18 ` Johan Hovold
2 siblings, 0 replies; 5+ messages in thread
From: Johan Hovold @ 2016-10-15 11:18 UTC (permalink / raw)
To: Viresh Kumar
Cc: Rui Miguel Silva, Johan Hovold, Alex Elder, Greg Kroah-Hartman,
linaro-kernel, linus.walleij, devel, linux-kernel
On Wed, Oct 12, 2016 at 08:02:21AM +0530, Viresh Kumar wrote:
> Some of the print messages are using the incorrect device pointer, fix
> them.
>
> Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
Acked-by: Johan Hovold <johan@kernel.org>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 2/2] Staging: greybus: uart: Use gbphy_dev->dev instead of bundle->dev
2016-10-12 2:32 ` [PATCH 2/2] Staging: greybus: uart: " Viresh Kumar
@ 2016-10-15 11:20 ` Johan Hovold
0 siblings, 0 replies; 5+ messages in thread
From: Johan Hovold @ 2016-10-15 11:20 UTC (permalink / raw)
To: Viresh Kumar
Cc: David Lin, Johan Hovold, Alex Elder, Greg Kroah-Hartman,
linaro-kernel, linus.walleij, devel, linux-kernel
On Wed, Oct 12, 2016 at 08:02:22AM +0530, Viresh Kumar wrote:
> Some of the print messages are using the incorrect device pointer, fix
> them.
>
> Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
Acked-by: Johan Hovold <johan@kernel.org>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2016-10-15 11:21 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-10-12 2:32 [PATCH 1/2] Staging: greybus: gpio: Use gbphy_dev->dev instead of bundle->dev Viresh Kumar
2016-10-12 2:32 ` [PATCH 2/2] Staging: greybus: uart: " Viresh Kumar
2016-10-15 11:20 ` Johan Hovold
2016-10-13 14:05 ` [PATCH 1/2] Staging: greybus: gpio: " Rui Miguel Silva
2016-10-15 11:18 ` Johan Hovold
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox