public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@kernel.org>
To: Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: linux-kernel@vger.kernel.org, Linux Weekly News <lwn@lwn.net>,
	Andi Kleen <ak@linux.intel.com>, Jiri Olsa <jolsa@kernel.org>,
	Arnaldo Carvalho de Melo <acme@redhat.com>,
	Peter Zijlstra <a.p.zijlstra@chello.nl>,
	Sukadev Bhattiprolu <sukadev@linux.vnet.ibm.com>
Subject: Re: [PATCH 04/27] perf list: Add support for listing only json events
Date: Sun, 16 Oct 2016 08:53:40 +0200	[thread overview]
Message-ID: <20161016065339.GA21445@gmail.com> (raw)
In-Reply-To: <1476375700-8896-5-git-send-email-acme@kernel.org>


* Arnaldo Carvalho de Melo <acme@kernel.org> wrote:

> From: Andi Kleen <ak@linux.intel.com>
> 
> Add an argument to only list json events. To be used for the command
> line completion script. This requires adding a new flag to the alias
> structure.
> 
> Committer notes:
> 
> Using it:
> 
>   $ perf list json

Sigh, this is a pretty poor user interface. :-(

 - 'JSON' is an internal data format used by the source code and by vendors to 
   publish event lists. perf might use something else in the future to store the 
   events (for example native .c/.h files) - we don't know. Why should the user 
   care or remember?

 - Also, even if the user remembers, it's not clear that using a weird acronym 
   that does not mean much in itself is a good way to key off a high level user 
   interface. Acronyms Seriously Suck.

 - The output of 'perf list help' is not really helpful either, so the user who 
   knows that there's "something" to list the vendor hardware events is still 
   stuck. Also, 'perf list hardware' will list the wrong things.

What we do know about the CPU vendor event names is that they are vendor specific, 
and that's a pretty stable property. So my suggestion would be to simply make it:

	perf list vendor

with perhaps add aliases as well:

	perf list model
	perf list cpu-model

... and 'perf list hardware' should probably also list all the vendor specific 
hardware events as well.

Could we please work a bit more on making vendor specific hardware event handling 
more usable to people who don't care about internals?

Thanks,

	Ingo

  reply	other threads:[~2016-10-16  6:53 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-13 16:21 [GIT PULL 00/27] perf/urgent fixes and JSON events files Arnaldo Carvalho de Melo
2016-10-13 16:21 ` [PATCH 01/27] perf top: Fix refreshing hierarchy entries on TUI Arnaldo Carvalho de Melo
2016-10-13 16:21 ` [PATCH 02/27] perf header: Set nr_numa_nodes only when we parsed all the data Arnaldo Carvalho de Melo
2016-10-13 16:21 ` [PATCH 03/27] perf jevents: Handle events including .c and .o Arnaldo Carvalho de Melo
2016-10-13 16:21 ` [PATCH 04/27] perf list: Add support for listing only json events Arnaldo Carvalho de Melo
2016-10-16  6:53   ` Ingo Molnar [this message]
2016-10-17 13:57     ` Andi Kleen
2016-10-17 14:28       ` [GIT PULL] " Arnaldo Carvalho de Melo
2016-10-17 14:49         ` Ingo Molnar
2016-10-13 16:21 ` [PATCH 05/27] perf tools: Handle completion of upper case events Arnaldo Carvalho de Melo
2016-10-13 16:21 ` [PATCH 06/27] perf jevents: Add BroadwellDE V5 event file Arnaldo Carvalho de Melo
2016-10-13 16:21 ` [PATCH 07/27] perf jevents: Add Broadwell V17 " Arnaldo Carvalho de Melo
2016-10-13 16:21 ` [PATCH 08/27] perf jevents: Add BroadwellX V10 " Arnaldo Carvalho de Melo
2016-10-13 16:21 ` [PATCH 09/27] perf jevents: Add Bonnell V4 " Arnaldo Carvalho de Melo
2016-10-13 16:21 ` [PATCH 10/27] perf jevents: Add Goldmont V8 " Arnaldo Carvalho de Melo
2016-10-13 16:21 ` [PATCH 11/27] perf jevents: Add Haswell V24 " Arnaldo Carvalho de Melo
2016-10-13 16:21 ` [PATCH 12/27] perf jevents: Add HaswellX V17 " Arnaldo Carvalho de Melo
2016-10-13 16:21 ` [PATCH 13/27] perf jevents: Add IvyBridge V18 " Arnaldo Carvalho de Melo
2016-10-13 16:21 ` [PATCH 14/27] perf jevents: Add IvyTown V19 " Arnaldo Carvalho de Melo
2016-10-13 16:21 ` [PATCH 15/27] perf jevents: Add Jaketown V20 " Arnaldo Carvalho de Melo
2016-10-13 16:21 ` [PATCH 16/27] perf jevents: Add KnightsLanding V9 " Arnaldo Carvalho de Melo
2016-10-13 16:21 ` [PATCH 17/27] perf jevents: Add NehalemEP V2 " Arnaldo Carvalho de Melo
2016-10-13 16:21 ` [PATCH 18/27] perf jevents: Add NehalemEX " Arnaldo Carvalho de Melo
2016-10-13 16:21 ` [PATCH 19/27] perf jevents: Add Skylake V24 " Arnaldo Carvalho de Melo
2016-10-13 16:21 ` [PATCH 20/27] perf jevents: Add Silvermont V13 " Arnaldo Carvalho de Melo
2016-10-13 16:21 ` [PATCH 21/27] perf jevents: Add SandyBridge V15 " Arnaldo Carvalho de Melo
2016-10-13 16:21 ` [PATCH 22/27] perf jevents: Add WestmereEP-DP V2 " Arnaldo Carvalho de Melo
2016-10-13 16:21 ` [PATCH 23/27] perf jevents: Add WestmereEP-SP " Arnaldo Carvalho de Melo
2016-10-13 16:21 ` [PATCH 24/27] perf jevents: Add WestmereEX " Arnaldo Carvalho de Melo
2016-10-13 16:21 ` [PATCH 25/27] perf jevents: Add power8 PMU events Arnaldo Carvalho de Melo
2016-10-13 16:21 ` [PATCH 26/27] perf jevents: Support couple more POWER8 PVRs in mapfile Arnaldo Carvalho de Melo
2016-10-13 16:21 ` [PATCH 27/27] perf jit: Fix build issue on Ubuntu Arnaldo Carvalho de Melo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161016065339.GA21445@gmail.com \
    --to=mingo@kernel.org \
    --cc=a.p.zijlstra@chello.nl \
    --cc=acme@kernel.org \
    --cc=acme@redhat.com \
    --cc=ak@linux.intel.com \
    --cc=jolsa@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lwn@lwn.net \
    --cc=sukadev@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox