From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756945AbcJPPjI (ORCPT ); Sun, 16 Oct 2016 11:39:08 -0400 Received: from up.free-electrons.com ([163.172.77.33]:56149 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753556AbcJPPjA (ORCPT ); Sun, 16 Oct 2016 11:39:00 -0400 Date: Sun, 16 Oct 2016 17:38:56 +0200 From: Boris Brezillon To: Colin King Cc: Artem Bityutskiy , Richard Weinberger , David Woodhouse , Brian Norris , linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH][V2] ubi: fix swapped arguments to call to ubi_alloc_aeb Message-ID: <20161016173856.11d486aa@bbrezillon> In-Reply-To: <20161015160011.27600-1-colin.king@canonical.com> References: <20161015160011.27600-1-colin.king@canonical.com> X-Mailer: Claws Mail 3.13.2 (GTK+ 2.24.30; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 15 Oct 2016 17:00:11 +0100 Colin King wrote: > From: Colin Ian King > > Static analysis by CoverityScan detected the ec and pnum > arguments are in the wrong order on a call to ubi_alloc_aeb. > Swap the order to fix this. > > Fixes: 91f4285fe389a27 ("UBI: provide helpers to allocate and free aeb elements") > Signed-off-by: Colin Ian King Reviewed-by: Boris Brezillon > --- > drivers/mtd/ubi/fastmap.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/mtd/ubi/fastmap.c b/drivers/mtd/ubi/fastmap.c > index d6384d9..4eed546 100644 > --- a/drivers/mtd/ubi/fastmap.c > +++ b/drivers/mtd/ubi/fastmap.c > @@ -287,7 +287,7 @@ static int update_vol(struct ubi_device *ubi, struct ubi_attach_info *ai, > > /* new_aeb is newer */ > if (cmp_res & 1) { > - victim = ubi_alloc_aeb(ai, aeb->ec, aeb->pnum); > + victim = ubi_alloc_aeb(ai, aeb->pnum, aeb->ec); > if (!victim) > return -ENOMEM; >