From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S964814AbcJQLXj (ORCPT ); Mon, 17 Oct 2016 07:23:39 -0400 Received: from mx1.redhat.com ([209.132.183.28]:41220 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933081AbcJQLXb (ORCPT ); Mon, 17 Oct 2016 07:23:31 -0400 Date: Mon, 17 Oct 2016 13:23:28 +0200 From: Jiri Olsa To: Andi Kleen Cc: acme@kernel.org, jolsa@kernel.org, sukadev@linux.vnet.ibm.com, eranian@google.com, linux-kernel@vger.kernel.org, Andi Kleen Subject: Re: [PATCH 07/10] perf, tools: Collapse identically named events in perf stat Message-ID: <20161017112328.GA24552@krava> References: <1476393332-20732-1-git-send-email-andi@firstfloor.org> <1476393332-20732-8-git-send-email-andi@firstfloor.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1476393332-20732-8-git-send-email-andi@firstfloor.org> User-Agent: Mutt/1.7.1 (2016-10-04) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.32]); Mon, 17 Oct 2016 11:23:30 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Oct 13, 2016 at 02:15:29PM -0700, Andi Kleen wrote: SNIP > + OPT_BOOLEAN(0, "no-merge", &no_merge, "Do not merge identical named events"), > OPT_STRING('x', "field-separator", &csv_sep, "separator", > "print counts with custom separator"), > OPT_CALLBACK('G', "cgroup", &evsel_list, "name", > diff --git a/tools/perf/util/evsel.h b/tools/perf/util/evsel.h > index b1503b0ecdff..4e3158fe79c2 100644 > --- a/tools/perf/util/evsel.h > +++ b/tools/perf/util/evsel.h > @@ -128,6 +128,7 @@ struct perf_evsel { > bool cmdline_group_boundary; > struct list_head config_terms; > int bpf_fd; > + bool alias; I think we should call this some other name, we already use alias for something else.. also alias->alias looks bad ;-) how about 'merged_stats' jirka