From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935649AbcJQQ2E (ORCPT ); Mon, 17 Oct 2016 12:28:04 -0400 Received: from one.firstfloor.org ([193.170.194.197]:40967 "EHLO one.firstfloor.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933564AbcJQQ15 (ORCPT ); Mon, 17 Oct 2016 12:27:57 -0400 Date: Mon, 17 Oct 2016 09:27:54 -0700 From: Andi Kleen To: Jiri Olsa Cc: Andi Kleen , acme@kernel.org, jolsa@kernel.org, sukadev@linux.vnet.ibm.com, eranian@google.com, linux-kernel@vger.kernel.org, Andi Kleen Subject: Re: [PATCH 09/10] perf, tools: Support DividedBy header in JSON event list Message-ID: <20161017162754.GM26852@two.firstfloor.org> References: <1476393332-20732-1-git-send-email-andi@firstfloor.org> <1476393332-20732-10-git-send-email-andi@firstfloor.org> <20161017114443.GE24552@krava> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20161017114443.GE24552@krava> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Oct 17, 2016 at 01:44:43PM +0200, Jiri Olsa wrote: > On Thu, Oct 13, 2016 at 02:15:31PM -0700, Andi Kleen wrote: > > From: Andi Kleen > > > > Add support for parsing the DividedBy header in the JSON event lists and > > storing them in the alias structure. > > I wish you'd add JSON tags always one by one as you did in here ;-) > > however Ithink we'll need more info here: > - what's the value? > - what's it going to be used for? That's all described in the next patch. But I can copy the description. > - looks like formula stuff, why post processing via python/perl can't be used in this case? It would be fairly complicated to interface that with event lists, and also still wouldn't work with standard perf stat. DividedBy already covers the majority of interesting cases and fits nicely with the existing frame work. If we wanted more complex formulas something with python would be probably needed, but I don't see the need yet. -Andi