From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S936497AbcJQRBg (ORCPT ); Mon, 17 Oct 2016 13:01:36 -0400 Received: from one.firstfloor.org ([193.170.194.197]:41104 "EHLO one.firstfloor.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933168AbcJQQ4o (ORCPT ); Mon, 17 Oct 2016 12:56:44 -0400 Date: Mon, 17 Oct 2016 09:56:42 -0700 From: Andi Kleen To: Jiri Olsa Cc: Andi Kleen , acme@kernel.org, jolsa@kernel.org, sukadev@linux.vnet.ibm.com, eranian@google.com, linux-kernel@vger.kernel.org, Andi Kleen Subject: Re: [PATCH 08/10] perf, tools: Expand PMU events by prefix match Message-ID: <20161017165642.GO26852@two.firstfloor.org> References: <1476393332-20732-1-git-send-email-andi@firstfloor.org> <1476393332-20732-9-git-send-email-andi@firstfloor.org> <20161017114038.GD24552@krava> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20161017114038.GD24552@krava> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > so there's a special treatment for uncore events, > what if user says 'uncore_box/..' then? It should work. There's nothing special for uncore later, this is just for convenience so that I have less to type. > > + if (!strncmp($1, name, strlen($1))) { > > + if (parse_events_copy_term_list(orig_terms, &terms)) > > + YYABORT; > > + if (!parse_events_add_pmu(data, list, pmu->name, terms)) > > + ok++; > > so we're ok if some of the events is not added? > do we warn at least? It would warn a lot because most PMUs don't have a given aliases. So you would get an warning for every extra PMU. Trying to warn only for those that have the alias would need a lot of extra tracking, and it didn't seem worth the complexity. -Andi