From: Jiri Olsa <jolsa@redhat.com>
To: Andi Kleen <andi@firstfloor.org>
Cc: acme@kernel.org, jolsa@kernel.org, sukadev@linux.vnet.ibm.com,
eranian@google.com, linux-kernel@vger.kernel.org,
Andi Kleen <ak@linux.intel.com>
Subject: Re: [PATCH 09/10] perf, tools: Support DividedBy header in JSON event list
Date: Mon, 17 Oct 2016 19:46:30 +0200 [thread overview]
Message-ID: <20161017174630.GD21680@krava> (raw)
In-Reply-To: <20161017174312.GC21680@krava>
On Mon, Oct 17, 2016 at 07:43:12PM +0200, Jiri Olsa wrote:
> On Mon, Oct 17, 2016 at 09:27:54AM -0700, Andi Kleen wrote:
> > On Mon, Oct 17, 2016 at 01:44:43PM +0200, Jiri Olsa wrote:
> > > On Thu, Oct 13, 2016 at 02:15:31PM -0700, Andi Kleen wrote:
> > > > From: Andi Kleen <ak@linux.intel.com>
> > > >
> > > > Add support for parsing the DividedBy header in the JSON event lists and
> > > > storing them in the alias structure.
> > >
> > > I wish you'd add JSON tags always one by one as you did in here ;-)
> > >
> > > however Ithink we'll need more info here:
> > > - what's the value?
> > > - what's it going to be used for?
> >
> > That's all described in the next patch. But I can copy the description.
> >
> > > - looks like formula stuff, why post processing via python/perl can't be used in this case?
> >
> > It would be fairly complicated to interface that with event lists, and
> > also still wouldn't work with standard perf stat.
> >
> > DividedBy already covers the majority of interesting cases and fits
> > nicely with the existing frame work. If we wanted more complex
> > formulas something with python would be probably needed, but I don't see
> > the need yet.
>
> so..
>
> - you put 'DividedBy' into JSON event's defition any further
^ without ;-)
> explanation how or why the format we use for event defs will
> be used now used to describe ratios
>
> - then you force perf stat to merge together all 'same' uncore events
> to get just one number..
>
> - then you display that ratio (just the number) in perf stat metrics output
> without any explanation or description
>
> I dont see that as a nicely fit, more like hack
>
> please let's go first to discuss the DividedBy being included
> in JSON defs, which is fragile topic to begin with
>
> thanks,
> jirka
next prev parent reply other threads:[~2016-10-17 17:46 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-13 21:15 Support Intel uncore event lists Andi Kleen
2016-10-13 21:15 ` [PATCH 01/10] perf, tools: Factor out scale conversion code Andi Kleen
2016-10-14 15:35 ` Arnaldo Carvalho de Melo
2016-10-14 15:45 ` Andi Kleen
2016-10-14 16:08 ` Arnaldo Carvalho de Melo
2016-10-14 16:15 ` Andi Kleen
2016-10-14 16:25 ` Arnaldo Carvalho de Melo
2016-10-14 16:36 ` Andi Kleen
2016-10-14 16:38 ` Arnaldo Carvalho de Melo
2016-10-13 21:15 ` [PATCH 02/10] perf, tools: Only print Using CPUID message once Andi Kleen
2016-10-14 15:44 ` Arnaldo Carvalho de Melo
2016-10-24 19:02 ` [tip:perf/core] perf pmu: " tip-bot for Andi Kleen
2016-10-13 21:15 ` [PATCH 03/10] perf, tools: Add support for parsing uncore json files Andi Kleen
2016-10-14 9:07 ` Jiri Olsa
2016-10-14 12:18 ` Jiri Olsa
2016-10-14 12:21 ` Jiri Olsa
2016-10-14 12:23 ` Jiri Olsa
2016-10-14 15:32 ` Andi Kleen
2016-10-13 21:15 ` [PATCH 04/10] perf, tools: Support per pmu json aliases Andi Kleen
2016-10-14 12:31 ` Jiri Olsa
2016-10-13 21:15 ` [PATCH 05/10] perf, tools: Support event aliases for non cpu// pmus Andi Kleen
2016-10-17 9:35 ` Jiri Olsa
2016-10-17 10:28 ` Jiri Olsa
2016-10-13 21:15 ` [PATCH 06/10] perf, tools: Add debug support for outputing alias string Andi Kleen
2016-10-13 21:15 ` [PATCH 07/10] perf, tools: Collapse identically named events in perf stat Andi Kleen
2016-10-17 10:55 ` Jiri Olsa
2016-10-17 11:23 ` Jiri Olsa
2016-10-17 11:26 ` Jiri Olsa
2016-10-17 16:30 ` Andi Kleen
2016-10-17 17:28 ` Jiri Olsa
2016-10-17 18:12 ` Andi Kleen
2016-10-13 21:15 ` [PATCH 08/10] perf, tools: Expand PMU events by prefix match Andi Kleen
2016-10-17 11:35 ` Jiri Olsa
2016-10-17 11:40 ` Jiri Olsa
2016-10-17 16:56 ` Andi Kleen
2016-10-17 17:26 ` Jiri Olsa
2016-10-13 21:15 ` [PATCH 09/10] perf, tools: Support DividedBy header in JSON event list Andi Kleen
2016-10-17 11:44 ` Jiri Olsa
2016-10-17 16:27 ` Andi Kleen
2016-10-17 17:43 ` Jiri Olsa
2016-10-17 17:46 ` Jiri Olsa [this message]
2016-10-17 18:28 ` Andi Kleen
2016-10-13 21:15 ` [PATCH 10/10] perf, tools, stat: Output generic dividedby metric Andi Kleen
2016-10-17 10:58 ` Support Intel uncore event lists Jiri Olsa
-- strict thread matches above, loose matches on Subject: below --
2016-11-19 0:36 Support Intel uncore event lists in perf Andi Kleen
2016-11-19 0:36 ` [PATCH 09/10] perf, tools: Support DividedBy header in JSON event list Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161017174630.GD21680@krava \
--to=jolsa@redhat.com \
--cc=acme@kernel.org \
--cc=ak@linux.intel.com \
--cc=andi@firstfloor.org \
--cc=eranian@google.com \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sukadev@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).