From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S938705AbcJQRqe (ORCPT ); Mon, 17 Oct 2016 13:46:34 -0400 Received: from mx1.redhat.com ([209.132.183.28]:34064 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932673AbcJQRqc (ORCPT ); Mon, 17 Oct 2016 13:46:32 -0400 Date: Mon, 17 Oct 2016 19:46:30 +0200 From: Jiri Olsa To: Andi Kleen Cc: acme@kernel.org, jolsa@kernel.org, sukadev@linux.vnet.ibm.com, eranian@google.com, linux-kernel@vger.kernel.org, Andi Kleen Subject: Re: [PATCH 09/10] perf, tools: Support DividedBy header in JSON event list Message-ID: <20161017174630.GD21680@krava> References: <1476393332-20732-1-git-send-email-andi@firstfloor.org> <1476393332-20732-10-git-send-email-andi@firstfloor.org> <20161017114443.GE24552@krava> <20161017162754.GM26852@two.firstfloor.org> <20161017174312.GC21680@krava> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20161017174312.GC21680@krava> User-Agent: Mutt/1.7.1 (2016-10-04) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.30]); Mon, 17 Oct 2016 17:46:32 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Oct 17, 2016 at 07:43:12PM +0200, Jiri Olsa wrote: > On Mon, Oct 17, 2016 at 09:27:54AM -0700, Andi Kleen wrote: > > On Mon, Oct 17, 2016 at 01:44:43PM +0200, Jiri Olsa wrote: > > > On Thu, Oct 13, 2016 at 02:15:31PM -0700, Andi Kleen wrote: > > > > From: Andi Kleen > > > > > > > > Add support for parsing the DividedBy header in the JSON event lists and > > > > storing them in the alias structure. > > > > > > I wish you'd add JSON tags always one by one as you did in here ;-) > > > > > > however Ithink we'll need more info here: > > > - what's the value? > > > - what's it going to be used for? > > > > That's all described in the next patch. But I can copy the description. > > > > > - looks like formula stuff, why post processing via python/perl can't be used in this case? > > > > It would be fairly complicated to interface that with event lists, and > > also still wouldn't work with standard perf stat. > > > > DividedBy already covers the majority of interesting cases and fits > > nicely with the existing frame work. If we wanted more complex > > formulas something with python would be probably needed, but I don't see > > the need yet. > > so.. > > - you put 'DividedBy' into JSON event's defition any further ^ without ;-) > explanation how or why the format we use for event defs will > be used now used to describe ratios > > - then you force perf stat to merge together all 'same' uncore events > to get just one number.. > > - then you display that ratio (just the number) in perf stat metrics output > without any explanation or description > > I dont see that as a nicely fit, more like hack > > please let's go first to discuss the DividedBy being included > in JSON defs, which is fragile topic to begin with > > thanks, > jirka