From: Jakub Kicinski <kubakici@wp.pl>
To: David Miller <davem@davemloft.net>
Cc: jarod@redhat.com, linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH v3 net-next 2/2] net: deprecate eth_change_mtu, remove usage
Date: Mon, 17 Oct 2016 18:04:15 +0100 [thread overview]
Message-ID: <20161017180415.3edc596d@jkicinski-Precision-T1700> (raw)
In-Reply-To: <20161017180027.4936fa15@jkicinski-Precision-T1700>
On Mon, 17 Oct 2016 18:00:27 +0100, Jakub Kicinski wrote:
> On Mon, 17 Oct 2016 12:49:54 -0400 (EDT), David Miller wrote:
> > From: Jakub Kicinski <kubakici@wp.pl>
> > Date: Mon, 17 Oct 2016 17:20:06 +0100
> >
> > > Please correct me if I'm wrong but it seems like we are now limiting
> > > _all_ ethernet drivers to ETH_DATA_LEN in net-next.
> >
> > No, because the driver can increase the netdev->max_mtu value as needed.
>
> But since almost no driver is doing that, yet, right now in net-next
> jumbo frames are not possible, no? I thought the idea was the leave
> the value at 0 so drivers can opt-in as needed but since setup_ether()
> is initializing to 1500 now all ethernet driver get a default of
> limiting to 1500.
>
> IOW this patch made checks which were done only in eth_change_mtu()
> mandatory for all drivers.
all ethernet drivers to be clear
next prev parent reply other threads:[~2016-10-17 17:06 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-12 20:11 [PATCH net-next 0/2] net: centralize net_device MTU bounds checking Jarod Wilson
2016-09-12 20:11 ` [PATCH net-next 1/2] net: centralize net_device min/max MTU checking Jarod Wilson
2016-09-12 20:11 ` [PATCH net-next 2/2] net: deprecate eth_change_mtu, remove usage Jarod Wilson
2016-09-13 21:59 ` kbuild test robot
2016-09-14 18:45 ` Jarod Wilson
2016-09-28 21:17 ` [PATCH v2 net-next 0/2] net: centralize net_device MTU bounds checking Jarod Wilson
2016-09-28 21:17 ` [PATCH v2 net-next 1/2] net: centralize net_device min/max MTU checking Jarod Wilson
2016-09-28 21:17 ` [PATCH v2 net-next 2/2] net: deprecate eth_change_mtu, remove usage Jarod Wilson
2016-09-28 22:20 ` [PATCH v2 net-next 0/2] net: centralize net_device MTU bounds checking Jarod Wilson
2016-09-28 22:20 ` [PATCH v2 net-next 1/2] net: centralize net_device min/max MTU checking Jarod Wilson
2016-09-30 9:37 ` Jakub Sitnicki
2016-10-03 2:43 ` David Miller
2016-10-03 17:46 ` Jarod Wilson
2016-10-08 2:04 ` [PATCH v3 net-next 0/2] net: centralize net_device MTU bounds checking Jarod Wilson
2016-10-08 2:04 ` [PATCH v3 net-next 1/2] net: centralize net_device min/max MTU checking Jarod Wilson
2016-10-08 2:04 ` [PATCH v3 net-next 2/2] net: deprecate eth_change_mtu, remove usage Jarod Wilson
2016-10-17 16:20 ` Jakub Kicinski
2016-10-17 16:49 ` David Miller
2016-10-17 17:00 ` Jakub Kicinski
2016-10-17 17:04 ` Jakub Kicinski [this message]
2016-10-17 17:15 ` David Miller
2016-10-17 17:20 ` Jakub Kicinski
2016-10-17 17:25 ` David Miller
2016-10-17 20:07 ` Jarod Wilson
2016-10-17 20:22 ` Jarod Wilson
2016-10-13 13:37 ` [PATCH v3 net-next 0/2] net: centralize net_device MTU bounds checking David Miller
2016-09-28 22:20 ` [PATCH v2 net-next 2/2] net: deprecate eth_change_mtu, remove usage Jarod Wilson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161017180415.3edc596d@jkicinski-Precision-T1700 \
--to=kubakici@wp.pl \
--cc=davem@davemloft.net \
--cc=jarod@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).