From: Stephen Boyd <sboyd@codeaurora.org>
To: Javier Martinez Canillas <javier@osg.samsung.com>
Cc: linux-kernel@vger.kernel.org,
Markus Reichl <m.reichl@fivetechno.de>,
Tobias Jakobi <tjakobi@math.uni-bielefeld.de>,
Michael Turquette <mturquette@baylibre.com>,
Chanwoo Choi <cw00.choi@samsung.com>,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
Krzysztof Kozlowski <krzk@kernel.org>,
linux-clk@vger.kernel.org
Subject: Re: [PATCH] clk: max77686: fix number of clocks setup for clk_hw based registration
Date: Mon, 17 Oct 2016 15:30:30 -0700 [thread overview]
Message-ID: <20161017223030.GI8871@codeaurora.org> (raw)
In-Reply-To: <1475765999-14366-1-git-send-email-javier@osg.samsung.com>
On 10/06, Javier Martinez Canillas wrote:
> The commit 9b4cac33adc7 ("clk: max77686: Migrate to clk_hw based OF and
> registration APIs") converted the driver to use the new provider API to
> register clocks using clk_hw.
>
> But unfortunately, in the conversion it missed to set the num_clks value
> which lead to the following error when trying to register a clk provider:
>
> [ 1.963782] of_clk_max77686_get: invalid index 0
> [ 1.967460] ERROR: could not get clock /rtc@10070000:rtc_src(1)
> [ 1.973638] s3c-rtc 10070000.rtc: failed to find rtc source clock
>
> Fix it by correctly set the max77686_clk_driver_data num_clks member.
>
> Fixes: 9b4cac33adc7 ("clk: max77686: Migrate to clk_hw based OF and registration APIs")
> Reported-by: Markus Reichl <m.reichl@fivetechno.de>
> Suggested-by: Tobias Jakobi <tjakobi@math.uni-bielefeld.de>
> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
> Tested-by: Markus Reichl <m.reichl@fivetechno.de>
>
> ---
Applied to clk-fixes
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
prev parent reply other threads:[~2016-10-17 22:30 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20161006150016epcas1p21acf81d53302f6917c38b3a451fcbe07@epcas1p2.samsung.com>
2016-10-06 14:59 ` [PATCH] clk: max77686: fix number of clocks setup for clk_hw based registration Javier Martinez Canillas
2016-10-06 17:22 ` Krzysztof Kozlowski
2016-10-07 0:36 ` Chanwoo Choi
2016-10-17 22:30 ` Stephen Boyd [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161017223030.GI8871@codeaurora.org \
--to=sboyd@codeaurora.org \
--cc=b.zolnierkie@samsung.com \
--cc=cw00.choi@samsung.com \
--cc=javier@osg.samsung.com \
--cc=krzk@kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=m.reichl@fivetechno.de \
--cc=mturquette@baylibre.com \
--cc=tjakobi@math.uni-bielefeld.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).