linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* 4.8.1 regression with cpufreq governors
@ 2016-10-18  0:46 Tim Walberg
  2016-10-18 21:10 ` Rafael J. Wysocki
  0 siblings, 1 reply; 5+ messages in thread
From: Tim Walberg @ 2016-10-18  0:46 UTC (permalink / raw)
  To: linux-kernel

May or may not be related to similar reports, but here's what I've just observed
on my system. Built a stock kernel from tags/v4.8.1, relevant cpufreq bits:

CONFIG_ACPI_CPU_FREQ_PSS=y
CONFIG_CPU_FREQ=y
CONFIG_CPU_FREQ_GOV_ATTR_SET=y
CONFIG_CPU_FREQ_GOV_COMMON=y
CONFIG_CPU_FREQ_STAT=y
CONFIG_CPU_FREQ_STAT_DETAILS=y
# CONFIG_CPU_FREQ_DEFAULT_GOV_PERFORMANCE is not set
# CONFIG_CPU_FREQ_DEFAULT_GOV_POWERSAVE is not set
# CONFIG_CPU_FREQ_DEFAULT_GOV_USERSPACE is not set
# CONFIG_CPU_FREQ_DEFAULT_GOV_ONDEMAND is not set
CONFIG_CPU_FREQ_DEFAULT_GOV_CONSERVATIVE=y
# CONFIG_CPU_FREQ_DEFAULT_GOV_SCHEDUTIL is not set
CONFIG_CPU_FREQ_GOV_PERFORMANCE=y
CONFIG_CPU_FREQ_GOV_POWERSAVE=m
CONFIG_CPU_FREQ_GOV_USERSPACE=m
CONFIG_CPU_FREQ_GOV_ONDEMAND=m
CONFIG_CPU_FREQ_GOV_CONSERVATIVE=y
CONFIG_CPU_FREQ_GOV_SCHEDUTIL=m
# CONFIG_X86_PCC_CPUFREQ is not set
CONFIG_X86_ACPI_CPUFREQ=m
CONFIG_X86_ACPI_CPUFREQ_CPB=y


Conservative is set as default governer, yet when boot completes, all CPUs are
pegged at the highest frequency. Changing governor to powersave knocks them all
down to the lowest available frequency. Putting them back on conservative (or
ondemand) results in no change in frequency, despite generating load. Switching
to performance of course kicks them back up to high frequency. Basically, the
governors don't seem to be ... governing.

-- 
twalberg@gmail.com, twalberg@comcast.net

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: 4.8.1 regression with cpufreq governors
  2016-10-18  0:46 4.8.1 regression with cpufreq governors Tim Walberg
@ 2016-10-18 21:10 ` Rafael J. Wysocki
  2016-10-19 14:06   ` Viresh Kumar
  2016-10-19 20:06   ` Tim Walberg
  0 siblings, 2 replies; 5+ messages in thread
From: Rafael J. Wysocki @ 2016-10-18 21:10 UTC (permalink / raw)
  To: Tim Walberg; +Cc: linux-kernel, Linux PM list, Viresh Kumar

On Monday, October 17, 2016 07:46:06 PM Tim Walberg wrote:
> May or may not be related to similar reports, but here's what I've just observed
> on my system. Built a stock kernel from tags/v4.8.1, relevant cpufreq bits:
> 
> CONFIG_ACPI_CPU_FREQ_PSS=y
> CONFIG_CPU_FREQ=y
> CONFIG_CPU_FREQ_GOV_ATTR_SET=y
> CONFIG_CPU_FREQ_GOV_COMMON=y
> CONFIG_CPU_FREQ_STAT=y
> CONFIG_CPU_FREQ_STAT_DETAILS=y
> # CONFIG_CPU_FREQ_DEFAULT_GOV_PERFORMANCE is not set
> # CONFIG_CPU_FREQ_DEFAULT_GOV_POWERSAVE is not set
> # CONFIG_CPU_FREQ_DEFAULT_GOV_USERSPACE is not set
> # CONFIG_CPU_FREQ_DEFAULT_GOV_ONDEMAND is not set
> CONFIG_CPU_FREQ_DEFAULT_GOV_CONSERVATIVE=y
> # CONFIG_CPU_FREQ_DEFAULT_GOV_SCHEDUTIL is not set
> CONFIG_CPU_FREQ_GOV_PERFORMANCE=y
> CONFIG_CPU_FREQ_GOV_POWERSAVE=m
> CONFIG_CPU_FREQ_GOV_USERSPACE=m
> CONFIG_CPU_FREQ_GOV_ONDEMAND=m
> CONFIG_CPU_FREQ_GOV_CONSERVATIVE=y
> CONFIG_CPU_FREQ_GOV_SCHEDUTIL=m
> # CONFIG_X86_PCC_CPUFREQ is not set
> CONFIG_X86_ACPI_CPUFREQ=m
> CONFIG_X86_ACPI_CPUFREQ_CPB=y
> 
> 
> Conservative is set as default governer, yet when boot completes, all CPUs are
> pegged at the highest frequency. Changing governor to powersave knocks them all
> down to the lowest available frequency. Putting them back on conservative (or
> ondemand) results in no change in frequency, despite generating load. Switching
> to performance of course kicks them back up to high frequency. Basically, the
> governors don't seem to be ... governing.

The "convervative" governor issue seems to be the one fixed recently
(http://git.kernel.org/cgit/linux/kernel/git/rafael/linux-pm.git/commit/?h=pm-cpufreq&id=abb6627910a1e783c8e034b35b7c80e5e7f98f41).

I'm not sure why "ondemand" behaves incorrectly for you though.

Thanks,
Rafael

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: 4.8.1 regression with cpufreq governors
  2016-10-18 21:10 ` Rafael J. Wysocki
@ 2016-10-19 14:06   ` Viresh Kumar
  2016-10-19 20:06   ` Tim Walberg
  1 sibling, 0 replies; 5+ messages in thread
From: Viresh Kumar @ 2016-10-19 14:06 UTC (permalink / raw)
  To: Rafael J. Wysocki; +Cc: Tim Walberg, linux-kernel, Linux PM list

On 18-10-16, 23:10, Rafael J. Wysocki wrote:
> On Monday, October 17, 2016 07:46:06 PM Tim Walberg wrote:
> > May or may not be related to similar reports, but here's what I've just observed
> > on my system. Built a stock kernel from tags/v4.8.1, relevant cpufreq bits:
> > 
> > CONFIG_ACPI_CPU_FREQ_PSS=y
> > CONFIG_CPU_FREQ=y
> > CONFIG_CPU_FREQ_GOV_ATTR_SET=y
> > CONFIG_CPU_FREQ_GOV_COMMON=y
> > CONFIG_CPU_FREQ_STAT=y
> > CONFIG_CPU_FREQ_STAT_DETAILS=y
> > # CONFIG_CPU_FREQ_DEFAULT_GOV_PERFORMANCE is not set
> > # CONFIG_CPU_FREQ_DEFAULT_GOV_POWERSAVE is not set
> > # CONFIG_CPU_FREQ_DEFAULT_GOV_USERSPACE is not set
> > # CONFIG_CPU_FREQ_DEFAULT_GOV_ONDEMAND is not set
> > CONFIG_CPU_FREQ_DEFAULT_GOV_CONSERVATIVE=y
> > # CONFIG_CPU_FREQ_DEFAULT_GOV_SCHEDUTIL is not set
> > CONFIG_CPU_FREQ_GOV_PERFORMANCE=y
> > CONFIG_CPU_FREQ_GOV_POWERSAVE=m
> > CONFIG_CPU_FREQ_GOV_USERSPACE=m
> > CONFIG_CPU_FREQ_GOV_ONDEMAND=m
> > CONFIG_CPU_FREQ_GOV_CONSERVATIVE=y
> > CONFIG_CPU_FREQ_GOV_SCHEDUTIL=m
> > # CONFIG_X86_PCC_CPUFREQ is not set
> > CONFIG_X86_ACPI_CPUFREQ=m
> > CONFIG_X86_ACPI_CPUFREQ_CPB=y
> > 
> > 
> > Conservative is set as default governer, yet when boot completes, all CPUs are
> > pegged at the highest frequency. Changing governor to powersave knocks them all
> > down to the lowest available frequency. Putting them back on conservative (or
> > ondemand) results in no change in frequency, despite generating load. Switching
> > to performance of course kicks them back up to high frequency. Basically, the
> > governors don't seem to be ... governing.
> 
> The "convervative" governor issue seems to be the one fixed recently
> (http://git.kernel.org/cgit/linux/kernel/git/rafael/linux-pm.git/commit/?h=pm-cpufreq&id=abb6627910a1e783c8e034b35b7c80e5e7f98f41).
> 
> I'm not sure why "ondemand" behaves incorrectly for you though.

@Tim: Can you please try this as well:

https://marc.info/?l=linux-kernel&m=147624218132250&w=2

Subject: [PATCH V2] cpufreq: skip invalid entries when searching the frequency

-- 
viresh

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: 4.8.1 regression with cpufreq governors
  2016-10-18 21:10 ` Rafael J. Wysocki
  2016-10-19 14:06   ` Viresh Kumar
@ 2016-10-19 20:06   ` Tim Walberg
  2016-10-20  3:29     ` Viresh Kumar
  1 sibling, 1 reply; 5+ messages in thread
From: Tim Walberg @ 2016-10-19 20:06 UTC (permalink / raw)
  To: Rafael J. Wysocki; +Cc: Tim Walberg, linux-kernel, Linux PM list, Viresh Kumar

This indeed turned out to be the fix.

On 10/18/2016 23:10 +0200, Rafael J. Wysocki wrote:
>>	On Monday, October 17, 2016 07:46:06 PM Tim Walberg wrote:
>>	> May or may not be related to similar reports, but here's what I've just observed
>>	> on my system. Built a stock kernel from tags/v4.8.1, relevant cpufreq bits:
>>	> 
>>	> CONFIG_ACPI_CPU_FREQ_PSS=y
>>	> CONFIG_CPU_FREQ=y
>>	> CONFIG_CPU_FREQ_GOV_ATTR_SET=y
>>	> CONFIG_CPU_FREQ_GOV_COMMON=y
>>	> CONFIG_CPU_FREQ_STAT=y
>>	> CONFIG_CPU_FREQ_STAT_DETAILS=y
>>	> # CONFIG_CPU_FREQ_DEFAULT_GOV_PERFORMANCE is not set
>>	> # CONFIG_CPU_FREQ_DEFAULT_GOV_POWERSAVE is not set
>>	> # CONFIG_CPU_FREQ_DEFAULT_GOV_USERSPACE is not set
>>	> # CONFIG_CPU_FREQ_DEFAULT_GOV_ONDEMAND is not set
>>	> CONFIG_CPU_FREQ_DEFAULT_GOV_CONSERVATIVE=y
>>	> # CONFIG_CPU_FREQ_DEFAULT_GOV_SCHEDUTIL is not set
>>	> CONFIG_CPU_FREQ_GOV_PERFORMANCE=y
>>	> CONFIG_CPU_FREQ_GOV_POWERSAVE=m
>>	> CONFIG_CPU_FREQ_GOV_USERSPACE=m
>>	> CONFIG_CPU_FREQ_GOV_ONDEMAND=m
>>	> CONFIG_CPU_FREQ_GOV_CONSERVATIVE=y
>>	> CONFIG_CPU_FREQ_GOV_SCHEDUTIL=m
>>	> # CONFIG_X86_PCC_CPUFREQ is not set
>>	> CONFIG_X86_ACPI_CPUFREQ=m
>>	> CONFIG_X86_ACPI_CPUFREQ_CPB=y
>>	> 
>>	> 
>>	> Conservative is set as default governer, yet when boot completes, all CPUs are
>>	> pegged at the highest frequency. Changing governor to powersave knocks them all
>>	> down to the lowest available frequency. Putting them back on conservative (or
>>	> ondemand) results in no change in frequency, despite generating load. Switching
>>	> to performance of course kicks them back up to high frequency. Basically, the
>>	> governors don't seem to be ... governing.
>>	
>>	The "convervative" governor issue seems to be the one fixed recently
>>	(http://git.kernel.org/cgit/linux/kernel/git/rafael/linux-pm.git/commit/?h=pm-cpufreq&id=abb6627910a1e783c8e034b35b7c80e5e7f98f41).
>>	
>>	I'm not sure why "ondemand" behaves incorrectly for you though.
>>	
>>	Thanks,
>>	Rafael
End of included message



-- 
twalberg@gmail.com, twalberg@comcast.net

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: 4.8.1 regression with cpufreq governors
  2016-10-19 20:06   ` Tim Walberg
@ 2016-10-20  3:29     ` Viresh Kumar
  0 siblings, 0 replies; 5+ messages in thread
From: Viresh Kumar @ 2016-10-20  3:29 UTC (permalink / raw)
  To: Tim Walberg, Rafael J. Wysocki, linux-kernel, Linux PM list

On 19-10-16, 15:06, Tim Walberg wrote:
> This indeed turned out to be the fix.

Really? How can this fix the ondemand governor thing?

Or is it that Ondemand never broke ?

-- 
viresh

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2016-10-20  3:29 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-10-18  0:46 4.8.1 regression with cpufreq governors Tim Walberg
2016-10-18 21:10 ` Rafael J. Wysocki
2016-10-19 14:06   ` Viresh Kumar
2016-10-19 20:06   ` Tim Walberg
2016-10-20  3:29     ` Viresh Kumar

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).