public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Namhyung Kim <namhyung@kernel.org>
To: Honggyu Kim <hong.gyu.kim@lge.com>
Cc: linux-kernel@vger.kernel.org,
	Arnaldo Carvalho de Melo <acme@redhat.com>,
	Steven Rostedt <rostedt@goodmis.org>
Subject: Re: [PATCH 1/3] tools lib traceevent: Add -O2 option to traceevent
Date: Tue, 18 Oct 2016 11:01:09 +0900	[thread overview]
Message-ID: <20161018020109.GA6099@danjae.aot.lge.com> (raw)
In-Reply-To: <20161017141712.11932-1-hong.gyu.kim@lge.com>

Hi Honggyu,

You need to CC relevant maintainers when you send patches to LKML.
For the libtraceevent, they are Arnaldo and Steven.  You can use
scripts/get_maintainer.pl for this job later.  In addition running
scripts/checkpatch.pl before sending patches is a good habit.

Arnaldo and Steve,

This is from uftrace building libtraceevent with the optimization flag
and we want to fix the upstream as well.

Thanks,
Namhyung


On Mon, Oct 17, 2016 at 11:17:10PM +0900, Honggyu Kim wrote:
> Since current traceevent somehow does not have an optimization flag,
> this patch just adds -O2 to optimize its code.
> 
> Signed-off-by: Honggyu Kim <hong.gyu.kim@lge.com>
> ---
>  tools/lib/traceevent/Makefile | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/lib/traceevent/Makefile b/tools/lib/traceevent/Makefile
> index 7851df1..56d223b 100644
> --- a/tools/lib/traceevent/Makefile
> +++ b/tools/lib/traceevent/Makefile
> @@ -124,7 +124,7 @@ else
>  endif
>  
>  # Append required CFLAGS
> -override CFLAGS += -fPIC
> +override CFLAGS += -O2 -fPIC
>  override CFLAGS += $(CONFIG_FLAGS) $(INCLUDES) $(PLUGIN_DIR_SQ)
>  override CFLAGS += $(udis86-flags) -D_GNU_SOURCE
>  
> -- 
> 2.10.0.rc2.dirty
> 

  parent reply	other threads:[~2016-10-18  2:02 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-17 14:17 [PATCH 1/3] tools lib traceevent: Add -O2 option to traceevent Honggyu Kim
2016-10-17 14:17 ` [PATCH 2/3] tools lib traceevent: Check the return value of asprintf Honggyu Kim
2016-10-18 17:59   ` Arnaldo Carvalho de Melo
2016-10-19  0:25     ` Namhyung Kim
2016-10-17 14:17 ` [PATCH 3/3] tools lib traceevent: Fix to set uninitialized variables Honggyu Kim
2016-10-18 17:59   ` Arnaldo Carvalho de Melo
2016-10-18  2:01 ` Namhyung Kim [this message]
2016-10-18 15:29   ` [PATCH 1/3] tools lib traceevent: Add -O2 option to traceevent Steven Rostedt
2016-10-19 17:48     ` Arnaldo Carvalho de Melo
2016-10-19 18:05       ` Arnaldo Carvalho de Melo
2016-10-19 18:06         ` Arnaldo Carvalho de Melo
2016-10-19 19:26           ` Steven Rostedt
2016-10-19 19:21         ` Steven Rostedt
2016-10-19 18:21       ` Steven Rostedt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161018020109.GA6099@danjae.aot.lge.com \
    --to=namhyung@kernel.org \
    --cc=acme@redhat.com \
    --cc=hong.gyu.kim@lge.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rostedt@goodmis.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox