From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S938865AbcJRQrJ (ORCPT <rfc822;w@1wt.eu>);
        Tue, 18 Oct 2016 12:47:09 -0400
Received: from smtprelay0036.hostedemail.com ([216.40.44.36]:39581 "EHLO
        smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL)
        by vger.kernel.org with ESMTP id S932960AbcJRQrB (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 18 Oct 2016 12:47:01 -0400
X-Session-Marker: 726F737465647440676F6F646D69732E6F7267
X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,rostedt@goodmis.org,:::::::::::::::::::::::,RULES_HIT:41:355:379:541:599:800:960:973:988:989:1260:1277:1311:1313:1314:1345:1359:1437:1515:1516:1518:1534:1538:1593:1594:1711:1714:1730:1747:1777:1792:2194:2199:2393:2553:2559:2562:3138:3139:3140:3141:3142:3351:3622:3870:3872:3876:5007:6261:6742:7514:7875:7903:10004:10400:10848:10967:11026:11232:11658:11914:12043:12740:12760:13069:13311:13357:13439:14181:14659:14721:21080:21433:30045:30054:30064:30090:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:4,LUA_SUMMARY:none
X-HE-Tag: wall70_1fcf4939b1c4e
X-Filterd-Recvd-Size: 1862
Date: Tue, 18 Oct 2016 12:46:57 -0400
From: Steven Rostedt <rostedt@goodmis.org>
To: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
Cc: Petr Mladek <pmladek@suse.com>,
        Andrew Morton <akpm@linux-foundation.org>, Jan Kara <jack@suse.cz>,
        Tejun Heo <tj@kernel.org>, Calvin Owens <calvinowens@fb.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        Mel Gorman <mgorman@techsingularity.net>,
        Ingo Molnar <mingo@redhat.com>, Peter Zijlstra <peterz@infradead.org>,
        linux-kernel@vger.kernel.org,
        Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
Subject: Re: [RFC][PATCHv3 3/6] printk: introduce per-cpu safe_print seq
 buffer
Message-ID: <20161018124657.76aef295@gandalf.local.home>
In-Reply-To: <20161018154045.7364-4-sergey.senozhatsky@gmail.com>
References: <20161018154045.7364-1-sergey.senozhatsky@gmail.com>
        <20161018154045.7364-4-sergey.senozhatsky@gmail.com>
X-Mailer: Claws Mail 3.13.2 (GTK+ 2.24.30; x86_64-pc-linux-gnu)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, 19 Oct 2016 00:40:42 +0900
Sergey Senozhatsky <sergey.senozhatsky@gmail.com> wrote:


> +
> +/*
> + * Returns with local IRQs disabled.
> + * Can be preempted by NMI.

It does? How does it return with IRQs disabled?

> + */
> +void __printk_safe_enter(void)
> +{
> +	this_cpu_inc(printk_safe_context);
> +}
> +
> +/*
> + * Restores local IRQs state saved in printk_safe_enter().
> + * Can be preempted by NMI.
> + */

How does this return with irqs enabled?

-- Steve

> +void __printk_safe_exit(void)
> +{
> +	this_cpu_dec(printk_safe_context);
> +}
> +