From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760720AbcJRNFU (ORCPT ); Tue, 18 Oct 2016 09:05:20 -0400 Received: from foss.arm.com ([217.140.101.70]:59422 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1760546AbcJRNFL (ORCPT ); Tue, 18 Oct 2016 09:05:11 -0400 Date: Tue, 18 Oct 2016 14:04:35 +0100 From: Mark Rutland To: Vlastimil Babka Cc: linux-kernel@vger.kernel.org, Andrew Morton , Mel Gorman , linux-mm@kvack.org, Joe Perches , Michal Hocko Subject: Re: [PATCH] mm: pagealloc: fix continued prints in show_free_areas Message-ID: <20161018130435.GD15639@leverpostej> References: <1476790457-7776-1-git-send-email-mark.rutland@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Oct 18, 2016 at 03:00:40PM +0200, Vlastimil Babka wrote: > On 10/18/2016 01:34 PM, Mark Rutland wrote: > >In show_free_areas, we miss KERN_CONT in a few cases, and as a result > >prints are unexpectedly split over a number of lines, making them > >difficult to read (in v4.9-rc1). > > > >This patch uses pr_cont (with uits implicit KERN_CONT) to mark all > >continued prints that occur withing a show_free_areas() call. Note that > >show_migration_types() is only called by show_free_areas(). > >Depending on CONFIG_NUMA a printk after show_node() may or may not be a > >continuation, but follows an explicit newline if not (and thus marking > >it as a continuation should not be harmful). > > I think this was already fixed: > > http://marc.info/?l=linux-mm&m=147623910031630&w=2 So it was; thanks for the pointer! Thanks, Mark.