From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933588AbcJRO47 (ORCPT ); Tue, 18 Oct 2016 10:56:59 -0400 Received: from mga02.intel.com ([134.134.136.20]:17572 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932230AbcJRO4w (ORCPT ); Tue, 18 Oct 2016 10:56:52 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.31,362,1473145200"; d="scan'208";a="181048462" Date: Tue, 18 Oct 2016 20:35:45 +0530 From: Vinod Koul To: Arnd Bergmann Cc: Dan Williams , dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] dmaengine: mmp_tdma: select GENERIC_ALLOCATOR Message-ID: <20161018150545.GE2467@localhost> References: <20161010120839.905144-1-arnd@arndb.de> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20161010120839.905144-1-arnd@arndb.de> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Oct 10, 2016 at 02:07:35PM +0200, Arnd Bergmann wrote: > build testing on x86 revealed a missing dependency that leads to a link error: > > drivers/dma/built-in.o: In function `mmp_tdma_prep_dma_cyclic': > mmp_tdma.c:(.text+0x9564): undefined reference to `gen_pool_dma_alloc' > drivers/dma/built-in.o: In function `mmp_tdma_free_chan_resources': > mmp_tdma.c:(.text+0x9675): undefined reference to `gen_pool_free' > drivers/dma/built-in.o: In function `mmp_tdma_probe': > mmp_tdma.c:(.text+0x9854): undefined reference to `of_gen_pool_get' > > This adds a 'select' statement to the driver to get it to build cleanly. Hi Arnd, I have already applied same change from Jérémy. > > Signed-off-by: Arnd Bergmann > --- > drivers/dma/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/dma/Kconfig b/drivers/dma/Kconfig > index af63a6bcf564..d882eb0fa551 100644 > --- a/drivers/dma/Kconfig > +++ b/drivers/dma/Kconfig > @@ -305,6 +305,7 @@ config MMP_TDMA > bool "MMP Two-Channel DMA support" > depends on ARCH_MMP || COMPILE_TEST > select DMA_ENGINE > + select GENERIC_ALLOCATOR > select MMP_SRAM if ARCH_MMP > help > Support the MMP Two-Channel DMA engine. > -- > 2.9.0 > -- ~Vinod