[PATCH] dmaengine: mmp_tdma: select GENERIC_ALLOCATOR

[PATCH] dmaengine: mmp_tdma: select GENERIC_ALLOCATOR

[Arnd Bergmann]

build testing on x86 revealed a missing dependency that leads to a link error:

drivers/dma/built-in.o: In function `mmp_tdma_prep_dma_cyclic':
mmp_tdma.c:(.text+0x9564): undefined reference to `gen_pool_dma_alloc'
drivers/dma/built-in.o: In function `mmp_tdma_free_chan_resources':
mmp_tdma.c:(.text+0x9675): undefined reference to `gen_pool_free'
drivers/dma/built-in.o: In function `mmp_tdma_probe':
mmp_tdma.c:(.text+0x9854): undefined reference to `of_gen_pool_get'

This adds a 'select' statement to the driver to get it to build cleanly.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 drivers/dma/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/dma/Kconfig b/drivers/dma/Kconfig
index af63a6bcf564..d882eb0fa551 100644
--- a/drivers/dma/Kconfig
+++ b/drivers/dma/Kconfig
@@ -305,6 +305,7 @@ config MMP_TDMA
 	bool "MMP Two-Channel DMA support"
 	depends on ARCH_MMP || COMPILE_TEST
 	select DMA_ENGINE
+	select GENERIC_ALLOCATOR
 	select MMP_SRAM if ARCH_MMP
 	help
 	  Support the MMP Two-Channel DMA engine.
-- 
2.9.0

Re: [PATCH] dmaengine: mmp_tdma: select GENERIC_ALLOCATOR

[Vinod Koul]

On Mon, Oct 10, 2016 at 02:07:35PM +0200, Arnd Bergmann wrote:
> build testing on x86 revealed a missing dependency that leads to a link error:
> 
> drivers/dma/built-in.o: In function `mmp_tdma_prep_dma_cyclic':
> mmp_tdma.c:(.text+0x9564): undefined reference to `gen_pool_dma_alloc'
> drivers/dma/built-in.o: In function `mmp_tdma_free_chan_resources':
> mmp_tdma.c:(.text+0x9675): undefined reference to `gen_pool_free'
> drivers/dma/built-in.o: In function `mmp_tdma_probe':
> mmp_tdma.c:(.text+0x9854): undefined reference to `of_gen_pool_get'
> 
> This adds a 'select' statement to the driver to get it to build cleanly.

Hi Arnd,

I have already applied same change from Jérémy.

> 
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
>  drivers/dma/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/dma/Kconfig b/drivers/dma/Kconfig
> index af63a6bcf564..d882eb0fa551 100644
> --- a/drivers/dma/Kconfig
> +++ b/drivers/dma/Kconfig
> @@ -305,6 +305,7 @@ config MMP_TDMA
>  	bool "MMP Two-Channel DMA support"
>  	depends on ARCH_MMP || COMPILE_TEST
>  	select DMA_ENGINE
> +	select GENERIC_ALLOCATOR
>  	select MMP_SRAM if ARCH_MMP
>  	help
>  	  Support the MMP Two-Channel DMA engine.
> -- 
> 2.9.0
> 

-- 
~Vinod

[PATCH] dmaengine: mmp_tdma: Select GENERIC_ALLOCATOR

[Borislav Petkov]

From: Borislav Petkov <bp@suse.de>

as the driver needs it. Build error caught with a randconfig build:

  drivers/built-in.o: In function `mmp_tdma_prep_dma_cyclic':
  mmp_tdma.c:(.text+0x1612d9): undefined reference to `gen_pool_dma_alloc'
  drivers/built-in.o: In function `mmp_tdma_free_chan_resources':
  mmp_tdma.c:(.text+0x161444): undefined reference to `gen_pool_free'
  drivers/built-in.o: In function `mmp_tdma_probe':
  mmp_tdma.c:(.text+0x1616ac): undefined reference to `of_gen_pool_get'
  make: *** [vmlinux] Error 1

Signed-off-by: Borislav Petkov <bp@suse.de>
Cc: Dan Williams <dan.j.williams@intel.com>
Cc: Vinod Koul <vinod.koul@intel.com>
Cc: dmaengine@vger.kernel.org
---
 drivers/dma/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/dma/Kconfig b/drivers/dma/Kconfig
index af63a6bcf564..e88a6ef03dcf 100644
--- a/drivers/dma/Kconfig
+++ b/drivers/dma/Kconfig
@@ -304,6 +304,7 @@ config MMP_PDMA
 config MMP_TDMA
 	bool "MMP Two-Channel DMA support"
 	depends on ARCH_MMP || COMPILE_TEST
+	select GENERIC_ALLOCATOR
 	select DMA_ENGINE
 	select MMP_SRAM if ARCH_MMP
 	help
-- 
2.10.0

Re: [PATCH] dmaengine: mmp_tdma: Select GENERIC_ALLOCATOR

[Vinod Koul]

On Thu, Nov 03, 2016 at 01:36:55PM +0100, Borislav Petkov wrote:
> From: Borislav Petkov <bp@suse.de>
> 
> as the driver needs it. Build error caught with a randconfig build:

Already fixed by commit d6619761068cf573cae406f176d00b82a39a37fc
:(dmaengine: mmp_tdma: add missing select GENERIC_ALLOCATOR in Kconfig)

You should see this in linux-next

-- 
~Vinod