From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935428AbcJRPUE (ORCPT ); Tue, 18 Oct 2016 11:20:04 -0400 Received: from mout.kundenserver.de ([212.227.126.130]:49473 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S935263AbcJRPTu (ORCPT ); Tue, 18 Oct 2016 11:19:50 -0400 From: Arnd Bergmann To: Mark Brown Cc: Arnd Bergmann , Daniel Mack , Haojian Zhuang , Robert Jarzmik , Liam Girdwood , linux-arm-kernel@lists.infradead.org, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Subject: [PATCH] ASoC: PXA: Brownstone needs I2C Date: Tue, 18 Oct 2016 17:18:58 +0200 Message-Id: <20161018151912.2742738-1-arnd@arndb.de> X-Mailer: git-send-email 2.9.0 X-Provags-ID: V03:K0:J4+zJVN6tIHFq7VguefqpIN9W1sicMEZrkeNBpowSziHRbt0PKM gKc87HqkKGjsb5Jn8CgEVAAaJgwfjwALeVjZQtlG89Tp0DhJVmqqqvWoKtNrOY0t89IM4BC wSzokpIQpvmoVW1nzSxY5Bp9MO78WZp1q3PD8TncbigQHYi9ZFPMOKGNGOGQmhJ5LvdBvtz u8L9Pv9bh9yX4UvWQ2veQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:4drUsyKWFv4=:+bR7JgYyX8RzQPstHMrQPD wFsaPPsc4gE5gx+uuyUhEWX2yYOxo8TTqh7UmxIBiWtjZAJEwlhl+9TVt8pfwmK00OMMEOsTu cyPCppekpT3w6Mz7LGR+eWDj0ofwPi5ZIdDTh/culcCZCkq//fcLkJP9FLvAFgtWfcz63jOgn Ewucqcv+XEtQMAaXadn/CSljwh8KiknWInnhUTKYZsSVYPdtWpenxKKNunqxR0PtFSFuINsTP /yFIVAllRlCqqKbmgov6iLblZTlRhnfizx1EKucp3VqGPKn32Z6QZXQIi33UaNHr0pl0+mAl+ t5qt8Au53wa1SKAxQ4lLARsEi4FNuPSN2TRpdvyMhtmSAFYpXDgmvssCvcTYn1OcdZlbU6K0j SsFmLJDPQqm0L3+WGGqVgFB1PV8ISb11OEi0kw+wX2ChqYJXa0f/3gU53eSgY7hYZPfzqItH2 7PkKngt3TIMRhwsEbCWlYW6gjHAzJp4GMKFtAsBYd6gHu7tznYZsNZIdnX+bk6AZsWDAPBodh UBAvtqfyBKNIW7YsPNvx6hLNq+/hPN3iTWHdg0JUDcFLcGE/EM5kYfWDPiuMT2+cc9Qiyu1ed W2EZGprNWm4NSdxpGbOXR9QDZlLanA97UwszTxlF1VrgPzkoiuWl1hf4898fnKyr1/nmhN2kU hj1hsaZG/RSy909qslQ7yh6np1zV/y2/6ElpaPLsZXMV1DS2IIbY72ECSSHr3PXQR7JQ= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org I rand into a new build error with SND_MMP_SOC_BROWNSTONE: warning: (SND_MMP_SOC_BROWNSTONE && SND_SOC_SAMSUNG_SMDK_WM8994 && SND_SOC_SMDK_WM8994_PCM && SND_SOC_LITTLEMILL) selects MFD_WM8994 which has unmet direct dependencies (HAS_IOMEM && I2C) drivers/mfd/wm8994-core.c:688:1: error: data definition has no type or storage class [-Werror] drivers/mfd/wm8994-core.c:688:1: error: type defaults to 'int' in declaration of 'module_i2c_driver' [-Werror=implicit-int] I don't see why this never showed up before, as the dependency seems to have been missing since the symbol was first introduced several years ago. This adds a dependency like the other drivers have. Signed-off-by: Arnd Bergmann --- sound/soc/pxa/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/pxa/Kconfig b/sound/soc/pxa/Kconfig index f2bf8661dd21..823b5a236d8d 100644 --- a/sound/soc/pxa/Kconfig +++ b/sound/soc/pxa/Kconfig @@ -208,7 +208,7 @@ config SND_PXA2XX_SOC_IMOTE2 config SND_MMP_SOC_BROWNSTONE tristate "SoC Audio support for Marvell Brownstone" - depends on SND_MMP_SOC && MACH_BROWNSTONE + depends on SND_MMP_SOC && MACH_BROWNSTONE && I2C select SND_MMP_SOC_SSPA select MFD_WM8994 select SND_SOC_WM8994 -- 2.9.0