From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1755414AbcJSBKp (ORCPT <rfc822;w@1wt.eu>);
        Tue, 18 Oct 2016 21:10:45 -0400
Received: from mail-pf0-f195.google.com ([209.85.192.195]:36424 "EHLO
        mail-pf0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1753216AbcJSBKi (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 18 Oct 2016 21:10:38 -0400
Date: Wed, 19 Oct 2016 10:10:32 +0900
From: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
        Petr Mladek <pmladek@suse.com>,
        Andrew Morton <akpm@linux-foundation.org>, Jan Kara <jack@suse.cz>,
        Tejun Heo <tj@kernel.org>, Calvin Owens <calvinowens@fb.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        Mel Gorman <mgorman@techsingularity.net>,
        Ingo Molnar <mingo@redhat.com>, Peter Zijlstra <peterz@infradead.org>,
        linux-kernel@vger.kernel.org,
        Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
Subject: Re: [RFC][PATCHv3 3/6] printk: introduce per-cpu safe_print seq
 buffer
Message-ID: <20161019011032.GA513@swordfish>
References: <20161018154045.7364-1-sergey.senozhatsky@gmail.com>
 <20161018154045.7364-4-sergey.senozhatsky@gmail.com>
 <20161018124657.76aef295@gandalf.local.home>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20161018124657.76aef295@gandalf.local.home>
User-Agent: Mutt/1.7.1 (2016-10-04)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On (10/18/16 12:46), Steven Rostedt wrote:
> > +
> > +/*
> > + * Returns with local IRQs disabled.
> > + * Can be preempted by NMI.
> 
> It does? How does it return with IRQs disabled?
> 
> > + */
> > +void __printk_safe_enter(void)
> > +{
> > +	this_cpu_inc(printk_safe_context);
> > +}
> > +
> > +/*
> > + * Restores local IRQs state saved in printk_safe_enter().
> > + * Can be preempted by NMI.
> > + */
> 
> How does this return with irqs enabled?

ah... leftovers. thanks, will correct.

	-ss