From: Jesse Brandeburg <jesse.brandeburg@intel.com>
To: Henrik Austad <henrik@austad.us>
Cc: <linux-kernel@vger.kernel.org>, <intel-wired-lan@lists.osuosl.org>
Subject: Re: [Intel-wired-lan] [PATCH] igb: add missing fields to TXDCTL-register
Date: Wed, 19 Oct 2016 07:25:10 -0700 [thread overview]
Message-ID: <20161019072510.00002b0e@intel.com> (raw)
In-Reply-To: <1476880679-16221-1-git-send-email-henrik@austad.us>
On Wed, 19 Oct 2016 14:37:59 +0200
Henrik Austad <henrik@austad.us> wrote:
> The current list of E1000_TXDCTL-registers is incomplete. This adds
> the missing parts for the Transmit Descriptor Control (TXDCTL)
> register.
>
> The rest of these values (threshold for descriptor read/write) for
> TXDCTL seems to be defined in igb/igb.h, not sure why this is split
> though.
Hi Henrik, thanks for helping with our code.
While totally correct, having defines added to the kernel that are not
being used anywhere in the code isn't really very useful. Often the
upstream maintainers/reviewers will reject a patch like this that just
adds to a .h file, because there are no actual users of the defines.
If the transmit or ethtool code were to use these (via the same patch)
or something like that, then the patch would be more likely to be
accepted.
Jesse
PS In the future no need to copy linux-kernel for patches going to our
submaintainer list.
next prev parent reply other threads:[~2016-10-19 14:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-19 12:37 [PATCH] igb: add missing fields to TXDCTL-register Henrik Austad
2016-10-19 14:25 ` Jesse Brandeburg [this message]
2016-10-19 15:08 ` [Intel-wired-lan] " Henrik Austad
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161019072510.00002b0e@intel.com \
--to=jesse.brandeburg@intel.com \
--cc=henrik@austad.us \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox