From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S942112AbcJSOZU (ORCPT ); Wed, 19 Oct 2016 10:25:20 -0400 Received: from mga03.intel.com ([134.134.136.65]:46558 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S942052AbcJSOZL (ORCPT ); Wed, 19 Oct 2016 10:25:11 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.31,514,1473145200"; d="scan'208";a="21358783" Date: Wed, 19 Oct 2016 07:25:10 -0700 From: Jesse Brandeburg To: Henrik Austad Cc: , Subject: Re: [Intel-wired-lan] [PATCH] igb: add missing fields to TXDCTL-register Message-ID: <20161019072510.00002b0e@intel.com> In-Reply-To: <1476880679-16221-1-git-send-email-henrik@austad.us> References: <1476880679-16221-1-git-send-email-henrik@austad.us> Organization: Intel Corp. X-Mailer: Claws Mail 3.12.0 (GTK+ 2.24.28; i686-w64-mingw32) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 19 Oct 2016 14:37:59 +0200 Henrik Austad wrote: > The current list of E1000_TXDCTL-registers is incomplete. This adds > the missing parts for the Transmit Descriptor Control (TXDCTL) > register. > > The rest of these values (threshold for descriptor read/write) for > TXDCTL seems to be defined in igb/igb.h, not sure why this is split > though. Hi Henrik, thanks for helping with our code. While totally correct, having defines added to the kernel that are not being used anywhere in the code isn't really very useful. Often the upstream maintainers/reviewers will reject a patch like this that just adds to a .h file, because there are no actual users of the defines. If the transmit or ethtool code were to use these (via the same patch) or something like that, then the patch would be more likely to be accepted. Jesse PS In the future no need to copy linux-kernel for patches going to our submaintainer list.