From: Greg KH <gregkh@linuxfoundation.org>
To: Roberto Sara <robsara@gmail.com>
Cc: jslaby@suse.com, linux-kernel@vger.kernel.org
Subject: Re: drivers/tty/serial/max310x doesn't support latest UART revision of MAX14830
Date: Wed, 19 Oct 2016 10:32:13 +0200 [thread overview]
Message-ID: <20161019083213.GA6727@kroah.com> (raw)
In-Reply-To: <CAHv5Snq5T6KtQ_kbmjHOtfS1-F_N2rm_SHTWqfdpywHQaVvG5Q@mail.gmail.com>
On Wed, Oct 19, 2016 at 10:25:41AM +0200, Roberto Sara wrote:
> Kernel 4.4.22
That's pretty old and obsolete, can you try 4.8?
> MAX310x_REV_MASK has a value of 0xfc which only allows for UART revisions of
> 0xb0 to 0xb3.
>
> The latest MAX14830 UARTS have revision number 0xb4. The data sheet only
> states that revisions start at 0xb0.
>
> I suggest a change of MAX310x_REV_MASK to 0xf8, which will allow revisions up
> to 0xb7
Great, can you send a patch that you have tested to work properly?
thanks,
greg k-h
next parent reply other threads:[~2016-10-19 14:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CAHv5Snq5T6KtQ_kbmjHOtfS1-F_N2rm_SHTWqfdpywHQaVvG5Q@mail.gmail.com>
2016-10-19 8:32 ` Greg KH [this message]
[not found] ` <CAHv5SnojBcEbuLJzLNS76PY0=EB+=Cvb-ZUmTfyeikJ224t23Q@mail.gmail.com>
2016-10-19 9:14 ` drivers/tty/serial/max310x doesn't support latest UART revision of MAX14830 Greg KH
[not found] <VI1PR0501MB2093567C1DB630B743CD0A0092D20@VI1PR0501MB2093.eurprd05.prod.outlook.com>
2016-10-19 8:18 ` gregkh
2016-10-19 15:03 ` Uwe Kleine-König
2016-10-19 16:03 ` gregkh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161019083213.GA6727@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=jslaby@suse.com \
--cc=linux-kernel@vger.kernel.org \
--cc=robsara@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox