From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S942454AbcJSOay (ORCPT <rfc822;w@1wt.eu>);
        Wed, 19 Oct 2016 10:30:54 -0400
Received: from mail.linuxfoundation.org ([140.211.169.12]:48131 "EHLO
        mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S942134AbcJSOau (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 19 Oct 2016 10:30:50 -0400
Date: Wed, 19 Oct 2016 10:32:13 +0200
From: Greg KH <gregkh@linuxfoundation.org>
To: Roberto Sara <robsara@gmail.com>
Cc: jslaby@suse.com, linux-kernel@vger.kernel.org
Subject: Re: drivers/tty/serial/max310x doesn't support latest UART revision
 of MAX14830
Message-ID: <20161019083213.GA6727@kroah.com>
References: <CAHv5Snq5T6KtQ_kbmjHOtfS1-F_N2rm_SHTWqfdpywHQaVvG5Q@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <CAHv5Snq5T6KtQ_kbmjHOtfS1-F_N2rm_SHTWqfdpywHQaVvG5Q@mail.gmail.com>
User-Agent: Mutt/1.7.1 (2016-10-04)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Oct 19, 2016 at 10:25:41AM +0200, Roberto Sara wrote:
> Kernel 4.4.22

That's pretty old and obsolete, can you try 4.8?

> MAX310x_REV_MASK has a value of 0xfc which only allows for UART revisions of
> 0xb0 to 0xb3.
> 
> The latest MAX14830 UARTS have revision number 0xb4.  The data sheet only
> states that revisions start at 0xb0.
> 
> I suggest a change of MAX310x_REV_MASK to 0xf8, which will allow revisions up
> to 0xb7

Great, can you send a patch that you have tested to work properly?

thanks,

greg k-h