From: Vinod Koul <vinod.koul@intel.com>
To: Colin King <colin.king@canonical.com>
Cc: Dan Williams <dan.j.williams@intel.com>,
dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dmaengine: omap-dma: initialize can_pause to false
Date: Wed, 19 Oct 2016 18:48:12 +0530 [thread overview]
Message-ID: <20161019131812.GL2467@localhost> (raw)
In-Reply-To: <20161019110553.26168-1-colin.king@canonical.com>
On Wed, Oct 19, 2016 at 12:05:53PM +0100, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> can_pause is not initialized so it contains garbage. Fix this
> by setting it to false.
>
> Found using static analysis with cppcheck.
It is usuallu helpful to show the warning generated by static tools.
Applied, anyway
--
~Vinod
prev parent reply other threads:[~2016-10-19 14:36 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-19 11:05 [PATCH] dmaengine: omap-dma: initialize can_pause to false Colin King
2016-10-19 13:18 ` Vinod Koul [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161019131812.GL2467@localhost \
--to=vinod.koul@intel.com \
--cc=colin.king@canonical.com \
--cc=dan.j.williams@intel.com \
--cc=dmaengine@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox