From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S941845AbcJSOWO (ORCPT ); Wed, 19 Oct 2016 10:22:14 -0400 Received: from mail-pf0-f173.google.com ([209.85.192.173]:36809 "EHLO mail-pf0-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S940708AbcJSOWK (ORCPT ); Wed, 19 Oct 2016 10:22:10 -0400 Date: Wed, 19 Oct 2016 19:21:17 +0530 From: Viresh Kumar To: Robert Jarzmik Cc: Daniel Mack , Haojian Zhuang , Rob Herring , Mark Rutland , Rafael Wysocki , linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org Subject: Re: [PATCH v2 2/4] ARM: dts: pxa: add pxa25x cpu operating points Message-ID: <20161019135117.GF11471@vireshk-i7> References: <1476561450-28407-1-git-send-email-robert.jarzmik@free.fr> <1476561450-28407-3-git-send-email-robert.jarzmik@free.fr> <20161018113944.GC11471@vireshk-i7> <87vawp4qv0.fsf@belgarion.home> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87vawp4qv0.fsf@belgarion.home> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 18-10-16, 17:30, Robert Jarzmik wrote: > Viresh Kumar writes: > > > On 15-10-16, 21:57, Robert Jarzmik wrote: > >> Add the relevant data taken from the PXA 25x Electrical, Mechanical, and > >> Thermal Specfication. This will be input data for cpufreq-dt driver. > >> > >> Signed-off-by: Robert Jarzmik > >> --- > >> arch/arm/boot/dts/pxa25x.dtsi | 25 +++++++++++++++++++++++++ > >> 1 file changed, 25 insertions(+) > >> > >> diff --git a/arch/arm/boot/dts/pxa25x.dtsi b/arch/arm/boot/dts/pxa25x.dtsi > >> index 0d1e012178c4..16b4e8bad4a5 100644 > >> --- a/arch/arm/boot/dts/pxa25x.dtsi > >> +++ b/arch/arm/boot/dts/pxa25x.dtsi > >> @@ -89,4 +89,29 @@ > >> clocks = <&clktimer>; > >> status = "okay"; > >> }; > >> + > >> + pxa250_opp_table: opp_table0 { > >> + compatible = "operating-points-v2"; > >> + > >> + opp@99500 { > > > > We have been keeping the values in ^^^ same as the values present > > below. Any specific reason for making it different here ? > No, that's a good comment, I'll change that. > > I wrote this incrementaly, first the node, then the opp-hz. Then I realized that > the source crystal, at 3.8684 MHz didn't provide a round 99.5 MHz core clock, > but a 99.5328 MHz clock. > > Anyway, I'll change that ... let's say into opp@99533 in this case ? Just write the whole value 99532800. -- viresh