From: Oleg Nesterov <oleg@redhat.com>
To: Michal Hocko <mhocko@kernel.org>
Cc: Leon Yu <chianglungyu@gmail.com>,
Andrew Morton <akpm@linux-foundation.org>,
Al Viro <viro@zeniv.linux.org.uk>,
Kees Cook <keescook@chromium.org>,
John Stultz <john.stultz@linaro.org>,
Mateusz Guzik <mguzik@redhat.com>,
Janis Danisevskis <jdanis@google.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] proc: fix NULL dereference when reading /proc/<pid>/auxv
Date: Wed, 19 Oct 2016 18:44:29 +0200 [thread overview]
Message-ID: <20161019164428.GE21216@redhat.com> (raw)
In-Reply-To: <20161019161731.GK24393@dhcp22.suse.cz>
On 10/19, Michal Hocko wrote:
>
> On Wed 19-10-16 18:12:08, Oleg Nesterov wrote:
> > On 10/19, Michal Hocko wrote:
> > >
> > > Why would we even want to open that file if there is no mm struct?
> >
> > Agreed this is strange, but I am not sure we can change this old
> > behaviour. Say, cat /proc/$pid-of-kthread/mem doesn't fail, it shows
> > the "empty mm".
>
> What kind of application would break?
I have no idea, probably nobody will ever notice this change, just
I am always nervous when it comes to user-visible changes.
But why do we want this change? Not that I am going to argue if you
submit a patch, but personally I see no real point.
Oleg.
next prev parent reply other threads:[~2016-10-19 16:45 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-19 13:59 [PATCH] proc: fix NULL dereference when reading /proc/<pid>/auxv Leon Yu
2016-10-19 14:13 ` Michal Hocko
2016-10-19 16:12 ` Oleg Nesterov
2016-10-19 16:17 ` Michal Hocko
2016-10-19 16:44 ` Oleg Nesterov [this message]
2016-10-19 17:00 ` Michal Hocko
2016-10-19 14:20 ` Al Viro
2016-10-19 14:51 ` Michal Hocko
2016-10-19 14:51 ` Leon Yu
2016-10-19 17:17 ` Michal Hocko
2016-10-20 12:32 ` Leon Yu
2016-10-20 12:44 ` Michal Hocko
2016-10-20 12:23 ` [PATCH v2] " Leon Yu
2016-10-20 17:04 ` Oleg Nesterov
2016-10-20 19:21 ` Michal Hocko
2016-10-21 12:47 ` Leon Yu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161019164428.GE21216@redhat.com \
--to=oleg@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=chianglungyu@gmail.com \
--cc=jdanis@google.com \
--cc=john.stultz@linaro.org \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mguzik@redhat.com \
--cc=mhocko@kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox